docs: drop 26.05 labels from minimal-install links on main#2243
Draft
kheiss-uwzoo wants to merge 5 commits into
Draft
docs: drop 26.05 labels from minimal-install links on main#2243kheiss-uwzoo wants to merge 5 commits into
kheiss-uwzoo wants to merge 5 commits into
Conversation
Rename the Helm README minimal-install section, keep a legacy #recommended-minimal-install-2605 alias, point extraction docs at blob/main, and use version-neutral prose in chart default notes.
Contributor
Greptile SummaryThis PR drops the
|
| Filename | Overview |
|---|---|
| nemo_retriever/helm/README.md | Section heading renamed from 'Recommended minimal install (26.05)' to 'Recommended minimal install'; legacy span anchor added for backward compat; three values-table rows updated from '26.05 installs' to 'default installs'; internal links updated to match. |
| docs/docs/extraction/deployment-options.md | Minimal-install cross-link updated from blob/26.05 to blob/main with version-neutral text; '(26.05)' removed from link label and surrounding prose. |
| docs/docs/extraction/prerequisites-support-matrix.md | Two links updated from blob/26.05 to blob/main (minimal-install and NIM Operator sub-stack); '26.05 production' phrasing replaced with 'production deployments'. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["deployment-options.md\nminimal-install link"] -->|blob/main + #recommended-minimal-install-2605| C
B["prerequisites-support-matrix.md\nminimal-install link"] -->|blob/main + #recommended-minimal-install-2605| C
C["helm/README.md\n### Recommended minimal install\n{ #recommended-minimal-install }"]
C --> D["span id='recommended-minimal-install-2605'\n(legacy anchor — preserves old bookmarks)"]
E["Internal README links\n(lines 191, 307, 399)"] -->|#recommended-minimal-install-2605| D
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["deployment-options.md\nminimal-install link"] -->|blob/main + #recommended-minimal-install-2605| C
B["prerequisites-support-matrix.md\nminimal-install link"] -->|blob/main + #recommended-minimal-install-2605| C
C["helm/README.md\n### Recommended minimal install\n{ #recommended-minimal-install }"]
C --> D["span id='recommended-minimal-install-2605'\n(legacy anchor — preserves old bookmarks)"]
E["Internal README links\n(lines 191, 307, 399)"] -->|#recommended-minimal-install-2605| D
Reviews (4): Last reviewed commit: "docs: restore caption links to #image-ca..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
493
to
494
| [Image captioning — NIM and hardware](https://docs.nvidia.com/nemo/retriever/latest/extraction/prerequisites-support-matrix/#image-captioning-nim-hardware) | ||
| for the product matrix. |
Contributor
There was a problem hiding this comment.
#image-captioning-nim-hardware doesn't exist
The link target #image-captioning-nim-hardware was introduced here (and again at line ~1156) but prerequisites-support-matrix.md still uses the explicit anchor { #image-captioning-2605 } — that section heading was not renamed in this PR. Any reader clicking this link on docs.nvidia.com will land on a broken fragment. The correct target remains #image-captioning-2605.
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/helm/README.md
Line: 493-494
Comment:
**Broken fragment: `#image-captioning-nim-hardware` doesn't exist**
The link target `#image-captioning-nim-hardware` was introduced here (and again at line ~1156) but `prerequisites-support-matrix.md` still uses the explicit anchor `{ #image-captioning-2605 }` — that section heading was not renamed in this PR. Any reader clicking this link on `docs.nvidia.com` will land on a broken fragment. The correct target remains `#image-captioning-2605`.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1156
to
1157
| - For **offline captioning**, enable | ||
| `nimOperator.nemotron_3_nano_omni_30b_a3b_reasoning` and point the pipeline |
Contributor
There was a problem hiding this comment.
This second occurrence also points to #image-captioning-nim-hardware, which doesn't exist in the published prerequisites-support-matrix page. The existing anchor #image-captioning-2605 should be used until the section heading in prerequisites-support-matrix.md is actually renamed to match.
Prompt To Fix With AI
This is a comment left during a code review.
Path: nemo_retriever/helm/README.md
Line: 1156-1157
Comment:
**Same broken fragment as line 493**
This second occurrence also points to `#image-captioning-nim-hardware`, which doesn't exist in the published `prerequisites-support-matrix` page. The existing anchor `#image-captioning-2605` should be used until the section heading in `prerequisites-support-matrix.md` is actually renamed to match.
How can I resolve this? If you propose a fix, please make it concise.Document GitHub Pages to docs.nvidia.com upload for release 26.05 with explicit 26.5.0 S3 paths, and align caption cross-links with the Helm README anchor rename from NVIDIA#2243.
…ain" This reverts commit e3fcffe.
Keep PR NVIDIA#2243 scoped to minimal-install de-versioning only; the support matrix anchor was not renamed on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main; keep a legacy#recommended-minimal-install-2605span so existing bookmarks still resolve.deployment-options.mdandprerequisites-support-matrix.mdminimal-install cross-links atblob/mainwith version-neutral link text.Follow-up to maintainer feedback on #2166 and #2203 — keeps OpenShift and extraction doc-sync PRs scoped to their original intent.
Test plan
#recommended-minimal-install-2605still resolves on the Helm READMEdeployment-options.mdand matrix optional-NIM paragraph link tomainHelm README(26.05)remains in minimal-install link labels on the three changed files