Skip to content

Pr cmake#8

Open
dirkcgrunwald wants to merge 18 commits into
NTIA:masterfrom
dirkcgrunwald:PR_cmake
Open

Pr cmake#8
dirkcgrunwald wants to merge 18 commits into
NTIA:masterfrom
dirkcgrunwald:PR_cmake

Conversation

@dirkcgrunwald

Copy link
Copy Markdown
  1. Add build multi-platform build support using cmake
  2. perform builds using github actions
  3. Fix minor Windows / C++ incompatibilities (intermixing wchar/char output)

@JayKickliter

JayKickliter commented Nov 9, 2023

Copy link
Copy Markdown

I cloned this PR and did my normal CMake based build steps and it built just fine. I didn't have to read any build instructions and there weren't any surprises. Built on macOS+M1.

@JayKickliter

Copy link
Copy Markdown

I've created rust wrapper for this branch and we're using it in production at decent scale. I'd love to see this work merged, otherwise there's a decent chance of having long-lived forks people depend on.

@wkozmaNTIA

Copy link
Copy Markdown
Member

We're going through some internal reorganization with the larger PropLib effort over this winter, which will include work being done in this branch. Sorry its taken longer than it probably should. Just how things are being prioritized.

@dirkcgrunwald

dirkcgrunwald commented Nov 15, 2023

Copy link
Copy Markdown
Author

I'm happy to help however I can. Good to know the patch has been useful.

@JayKickliter - I'd be interested in learning about the project you're doing. Looking at the HexTree and geoprop repos, it looks like you're developing something that I had been hoping to work on within NSF SpectrumX similar to what e.g. https://cloudrf.com/ does but in a way that can support open datasets and new prop models.

Email is grunwald@colorado.edu

@JayKickliter

Copy link
Copy Markdown

@dirkcgrunwald you nailed what we're doing. I'll follow up with an email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants