[Feat] 1차 세미나 재제출#8
Open
SeoyoungOhMe wants to merge 1 commit into
Open
Conversation
HELLOHIDI
reviewed
Jun 20, 2024
HELLOHIDI
left a comment
HELLOHIDI
left a comment
Contributor
There was a problem hiding this comment.
2차 과제 반영할때 오토레이아웃 정확히 해보기! 고생햇어요!
| @@ -0,0 +1,136 @@ | |||
| import Foundation | |||
Contributor
There was a problem hiding this comment.
UIKit안에 Foundation도 포함되어 있어서 한개만 써줘도 됩니다!
Collaborator
Author
There was a problem hiding this comment.
오 그렇군요!! 몰랐네요 ㅎㅎ
| import Foundation | ||
| import UIKit | ||
|
|
||
| final class LoginViewController: UIViewController, UITextFieldDelegate { |
Collaborator
Author
There was a problem hiding this comment.
원래는 노션에 있는 코드대로 썼는데...ㅎㅋㅎ찾아보니까 final을 쓰면 더 이상 상속이 필요없음을 명시할 수 있어서 런타임 성능을 향상시킬 수 있다고 하네요!! 그동안 이유는 생각 못하고 당연하게 받아들였네요,,😗
|
|
||
| /** 변수 초기화 **/ | ||
| private let titleLabel: UILabel = { | ||
| let label = UILabel(frame: CGRect(x: 69, y: 161, width: 236, height: 44)) |
Contributor
There was a problem hiding this comment.
이 부분은 다음 과제에서 오토 레이아웃으로 변경해보면 좋을거 같아요~!
Comment on lines
+74
to
+75
| idTextField.delegate = self | ||
| passwordTextField.delegate = self |
Contributor
There was a problem hiding this comment.
이런부분들도 setDelegate() 메소드를 만들어서 분리해둬도 좋을거 같아요! 생명주기 메소드에 너무 많은게 들어가면 복잡해보일 수 있기 때문에!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
👷 작업한 내용
1차 세미나 과제 다시해서 제출
UIComponent들의 속성들을 추가
=>
LoginVC에textField.layer.cornerRadius = 8나button.isEnabled = false사용UITextFieldDelegate 추가(
LoginVC에서 텍스트 필드 관리)=> 텍스트필드 입력 시 테두리 색 변경
=> 텍스트필드 입력 완료 후 키보드 다운 구현
=> 텍스트가 채워지면 특정 버튼 활성화
=> 텍스트필드 선택 후 뷰 터치하면 키보드 다운 구현
=> 텍스트필드 선택 후 뷰 올리기(collectionview 에 inset 부여)
피그마에 있는 폰트(Pretendard)와 이미지 에셋을 추가
🚨 참고 사항
📸 스크린샷