Fix Time data sharing mutations and missing since guard#115
Open
arpitjain099 wants to merge 1 commit into
Open
Fix Time data sharing mutations and missing since guard#115arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110.\n\nTime now copies incoming arrays (including Time->Time) so tz/origin/displacement shifts stay local to each instance.\nconstant_time() now returns an isolated copy so one caller cannot mutate all constant-time users.\nparse_time_offset() now handles units without "since" by warning and falling back to the default offset path.\n\nAdded regression tests for input-array mutation, Time-from-Time sharing, constant_time isolation, and parse_time_offset("days") fallback behavior.\n\nVerification:\n- python3 -m pytest gridded/tests/test_time_issue_110.py\n- python3 -m pytest gridded/tests/test_time.py -k "new_tz_offset or constant_time or parse_time_offset"\n- python3 -m ruff check gridded/time.py gridded/tests/test_time_issue_110.py