Skip to content

Add close()/context-manager support to Dataset#114

Open
arpitjain099 wants to merge 1 commit into
NOAA-ORR-ERD:mainfrom
arpitjain099:chore/add-dataset-close-context-109
Open

Add close()/context-manager support to Dataset#114
arpitjain099 wants to merge 1 commit into
NOAA-ORR-ERD:mainfrom
arpitjain099:chore/add-dataset-close-context-109

Conversation

@arpitjain099

Copy link
Copy Markdown

This adds deterministic cleanup for Dataset-backed netCDF handles.

  • add Dataset.close() and context-manager support for with Dataset.from_netCDF(...)
  • make close() idempotent and safe during object cleanup
  • add regression tests that assert the handle closes via both close() and context-manager exit

Closes #109.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gridded.Dataset has no close()/context manager: netCDF handle held until GC, file locked on Windows (WinError 32)

1 participant