Skip to content

[rrfs-nco] Add a clear WARNING message for missing RAVE data#1566

Open
ShunLiu-NOAA wants to merge 1 commit into
NOAA-EMC:rrfs-ncofrom
ShunLiu-NOAA:clear_rave_warning_message
Open

[rrfs-nco] Add a clear WARNING message for missing RAVE data#1566
ShunLiu-NOAA wants to merge 1 commit into
NOAA-EMC:rrfs-ncofrom
ShunLiu-NOAA:clear_rave_warning_message

Conversation

@ShunLiu-NOAA

Copy link
Copy Markdown
Contributor

DESCRIPTION OF CHANGES:

  • Add a clear WARNING message for missing RAVE data based on Wei and Jame's suggestion.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

  • Fixes the issue(s) mentioned in #9999

CONTRIBUTORS (optional):

@ShunLiu-NOAA ShunLiu-NOAA marked this pull request as ready for review June 24, 2026 14:53
@MatthewPyle-NOAA

Copy link
Copy Markdown
Contributor

@ShunLiu-NOAA there are other warning prints in the python code. I started some work on it (on dogwood) as /lfs/h2/emc/lam/noscrub/Matthew.Pyle/rrfs-workflow_ravefix/ush/generate_fire_emissions.py, but haven't finished it yet.

@ShunLiu-NOAA

Copy link
Copy Markdown
Contributor Author

@ShunLiu-NOAA there are other warning prints in the python code. I started some work on it (on dogwood) as /lfs/h2/emc/lam/noscrub/Matthew.Pyle/rrfs-workflow_ravefix/ush/generate_fire_emissions.py, but haven't finished it yet.

@MatthewPyle-NOAA , @WeiWei-NCO and @JamesPolly-NCO , Will it be clear enough if we only give one WARNING from "exrrfs_process_smoke.sh"?

@JamesPolly-NCO

Copy link
Copy Markdown
Collaborator

@ShunLiu-NOAA thank you for checking. We recently made some changes to the process_smoke jobs that result in both an email and warning messages in the output job log (example path shown below). I personally feel that no more functionality is needed here given these updates.

/lfs/h1/ops/test/output/20260623/rrfs_det_process_smoke_spinup_03.o270526814

@ShunLiu-NOAA

Copy link
Copy Markdown
Contributor Author

@JamesPolly-NCO To clarify, does generate_fire_emissions.py handle the warning adequately on its own, meaning we don't need to update exrrfs_process_smoke.sh? Additionally, I don't think we need to email this warning message to the team. The workflow should continue running successfully even without this job.

@JamesPolly-NCO

Copy link
Copy Markdown
Collaborator

@ShunLiu-NOAA Let's separate your concerns:

@ShunLiu-NOAA

Copy link
Copy Markdown
Contributor Author

Thanks for the clarification. I'll go ahead and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants