[rrfs-nco] Add exception handling for missing enkf lbc input on GEFS data#1556
Open
lgannoaa wants to merge 2 commits into
Open
[rrfs-nco] Add exception handling for missing enkf lbc input on GEFS data#1556lgannoaa wants to merge 2 commits into
lgannoaa wants to merge 2 commits into
Conversation
MatthewPyle-NOAA
approved these changes
Jun 18, 2026
MatthewPyle-NOAA
left a comment
Contributor
There was a problem hiding this comment.
But also wondering if we could just get rid of the print (at line 417 now) to inform that data isn't available for that forecast hour. Since that will always be true, does it need to be said?
ShunLiu-NOAA
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following:
Please confirm our understanding that missing one of the GEFS input files would result in the "Missing" message above, and that time interpolation would be performed, but this interpolation is not possible when all of the GEFS files are missing, and thus result in the failure captured in the output log above.
Solution: The required 3 hours GEFS data are required. Application logic added for exception handling to FATAL fail the job if those file found missing.
The "Missing" message above needs a "WARNING: " prefix added to it.
Solution: Modified the message to identify file that is not generated by operational GEFS.
This is an ops serviceability concern. The current "FATAL" message shown above references a file in $DATA which originated from $COMROOT/gefs. It would be best if the fatal message indicated that original destination.
One way to do this is to modify the existing error messaging to mention the original location.
Another way to do this is to inject a new check in advance of where the code current fails. The check would simply see if any of these GEFS files can be found in $COMROOT/gefs and immediately FATAL (with helpful error messaging) if not.
Solution: Implement exception handling to display which GEFS data is missing from the operational GEFS location.
REFS #1536