Skip to content

[rrfs-nco] Add exception handling for missing enkf lbc input on GEFS data#1556

Open
lgannoaa wants to merge 2 commits into
NOAA-EMC:rrfs-ncofrom
lgannoaa:feature/enkf_data_dependency
Open

[rrfs-nco] Add exception handling for missing enkf lbc input on GEFS data#1556
lgannoaa wants to merge 2 commits into
NOAA-EMC:rrfs-ncofrom
lgannoaa:feature/enkf_data_dependency

Conversation

@lgannoaa

Copy link
Copy Markdown
Contributor

Address the following:

  1. Please confirm our understanding that missing one of the GEFS input files would result in the "Missing" message above, and that time interpolation would be performed, but this interpolation is not possible when all of the GEFS files are missing, and thus result in the failure captured in the output log above.
    Solution: The required 3 hours GEFS data are required. Application logic added for exception handling to FATAL fail the job if those file found missing.

  2. The "Missing" message above needs a "WARNING: " prefix added to it.
    Solution: Modified the message to identify file that is not generated by operational GEFS.

  3. This is an ops serviceability concern. The current "FATAL" message shown above references a file in $DATA which originated from $COMROOT/gefs. It would be best if the fatal message indicated that original destination.
    One way to do this is to modify the existing error messaging to mention the original location.
    Another way to do this is to inject a new check in advance of where the code current fails. The check would simply see if any of these GEFS files can be found in $COMROOT/gefs and immediately FATAL (with helpful error messaging) if not.
    Solution: Implement exception handling to display which GEFS data is missing from the operational GEFS location.

REFS #1536

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But also wondering if we could just get rid of the print (at line 417 now) to inform that data isn't available for that forecast hour. Since that will always be true, does it need to be said?

@MatthewPyle-NOAA MatthewPyle-NOAA changed the title Add exception handling for missing enkf lbc input on GEFS data [rrfs-nco] Add exception handling for missing enkf lbc input on GEFS data Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants