Skip to content

(dev/gfs.v17) Fix 2-meter water vapor moist bias in western US#5011

Merged
DavidHuber-NOAA merged 12 commits into
NOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:fix/q2m
Jun 18, 2026
Merged

(dev/gfs.v17) Fix 2-meter water vapor moist bias in western US#5011
DavidHuber-NOAA merged 12 commits into
NOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:fix/q2m

Conversation

@DavidHuber-NOAA

@DavidHuber-NOAA DavidHuber-NOAA commented Jun 12, 2026

Copy link
Copy Markdown
Member

Description

This resolves the moist bias seen in 2-meter water vapor in the western US.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

How has this been tested?

Initial WCOSS2 CI testing passed. Offline tests of gfs-utils were run and passed by @BoCui-NOAA. UFS WM, and UPP tests were passed in their respective PRs (ufs-community/ufs-weather-model#3252 and NOAA-EMC/UPP#1548). Additional tests are underway.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA

Copy link
Copy Markdown
Member Author

Initial tests all passed on WCOSS2. Noting that the UPP and WM still need to be updated to the official hashes.

Mon Jun 15 13:19:54 UTC 2026
******** C48_ATM_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 12 2026 18:20:17    Jun 12 2026 20:35:36

******** C48mx500_3DVarAOWCDA_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 12 2026 18:20:39    Jun 12 2026 19:40:26
202103250000        Done    Jun 12 2026 18:20:39    Jun 12 2026 21:20:25

******** C48mx500_hybAOWCDA_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 12 2026 18:20:36    Jun 12 2026 19:40:49
202103250000        Done    Jun 12 2026 18:20:36    Jun 12 2026 20:50:40

******** C48_S2SW_extended_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 12 2026 18:20:27    Jun 15 2026 13:19:44
202103231800        Done    Jun 12 2026 18:20:27    Jun 12 2026 21:50:46

******** C96_atm3DVar_extended_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 12 2026 18:20:24    Jun 12 2026 19:40:20
202112210000        Done    Jun 12 2026 18:20:24    Jun 13 2026 00:10:26
202112210600        Done    Jun 12 2026 18:20:24    Jun 13 2026 01:05:36
202112211200        Done    Jun 12 2026 19:45:17    Jun 13 2026 02:20:25
202112211800        Done    Jun 13 2026 00:15:20    Jun 13 2026 04:50:21

******** C96C48_hybatmDA_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 12 2026 18:20:40    Jun 12 2026 19:40:32
202112210000        Done    Jun 12 2026 18:20:40    Jun 12 2026 22:00:53
202112210600        Done    Jun 12 2026 18:20:40    Jun 12 2026 21:55:33

******** C96C48_hybatmsnowDA_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 12 2026 18:20:21    Jun 12 2026 19:40:36
202112201800        Done    Jun 12 2026 18:20:21    Jun 12 2026 21:50:22
202112210000        Done    Jun 12 2026 18:20:21    Jun 12 2026 21:45:14

******** C96C48_hybatmsoilDA_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202205150600        Done    Jun 12 2026 18:20:40    Jun 12 2026 19:40:45
202205151200        Done    Jun 12 2026 18:20:40    Jun 12 2026 21:50:15
202205151800        Done    Jun 12 2026 18:20:40    Jun 12 2026 21:50:15

******** C96C48mx500_S2SW_cyc_gfs_q2m_fix ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 12 2026 18:20:46    Jun 12 2026 19:40:16
202112201800        Done    Jun 12 2026 18:20:46    Jun 12 2026 22:20:26
202112210000        Done    Jun 12 2026 18:20:46    Jun 12 2026 22:45:13
202112211800        Done    Jun 12 2026 19:45:18    Jun 12 2026 22:55:35

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review June 15, 2026 16:00
@DavidHuber-NOAA

Copy link
Copy Markdown
Member Author

Opening for review, but adding a needs submodule update label while upstream submodules are being updated.

@DavidHuber-NOAA DavidHuber-NOAA added the needs submodule update Requires submodule PRs to be merged label Jun 15, 2026
@WenMeng-NOAA

Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA The ufs-weather-model production/GFS.v17 branch has committed @d4b7b56 to include updates for this 2-m dewpoint issue. Please sync your branch accordingly. Note: @barlage would like to keep these 2-m dewpoint-related changes in the dev/gfs.v17 branch and not sync them to the develop branch, as they are intended only for the GFS v17 implementation.

@JessicaMeixner-NOAA

Copy link
Copy Markdown
Contributor

I will make another round of CI tests manually updating the ufs-weather-model hash to make sure this is ready to be merged tomorrow morning.

@DavidHuber-NOAA DavidHuber-NOAA removed the needs submodule update Requires submodule PRs to be merged label Jun 18, 2026
@DavidHuber-NOAA

Copy link
Copy Markdown
Member Author

@JessicaMeixner-NOAA @WenMeng-NOAA the WM hash has been updated. I have removed the 'needs submodule update' label and am now adding reviewers. Please let me know how testing went.

@BoCui-NOAA

Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA I checked the gfs-utils submodule in this PR, and it points to the NOAA-EMC/gfs-utils repository on the production/GFS.v17.0.0 branch at commit 7f6e742 ( bufr q2m adjustment). Looks good.

@WenMeng-NOAA WenMeng-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the hash of ufs_model.fd looks good to me,

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C48_ATM_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 17 2026 17:55:25    Jun 17 2026 19:25:34

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C48mx500_3DVarAOWCDA_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 17 2026 17:55:25    Jun 17 2026 18:15:13
202103250000        Done    Jun 17 2026 17:55:25    Jun 17 2026 20:10:45

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C48mx500_hybAOWCDA_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Jun 17 2026 17:55:19    Jun 17 2026 18:15:36
202103250000        Done    Jun 17 2026 17:55:19    Jun 17 2026 19:55:46

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C48_S2SW_extended_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Jun 17 2026 17:55:17    Jun 17 2026 21:10:45
202103231800        Done    Jun 17 2026 17:55:17    Jun 17 2026 21:00:12

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C96_atm3DVar_extended_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 17 2026 17:55:23    Jun 17 2026 18:15:36
202112210000        Done    Jun 17 2026 17:55:23    Jun 17 2026 23:05:40
202112210600        Done    Jun 17 2026 17:55:23    Jun 18 2026 00:05:39
202112211200        Done    Jun 17 2026 18:20:34    Jun 18 2026 01:20:37
202112211800        Done    Jun 17 2026 23:10:37    Jun 18 2026 03:50:18

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C96C48_hybatmDA_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Jun 17 2026 17:55:11    Jun 17 2026 18:20:40
202112210000        Done    Jun 17 2026 17:55:11    Jun 17 2026 20:50:48
202112210600        Done    Jun 17 2026 17:55:11    Jun 17 2026 21:00:51

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C96C48_hybatmsnowDA_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 17 2026 17:55:42    Jun 17 2026 18:25:38
202112201800        Done    Jun 17 2026 17:55:42    Jun 17 2026 21:00:55
202112210000        Done    Jun 17 2026 17:55:42    Jun 17 2026 21:00:55

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C96C48_hybatmsoilDA_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202205150600        Done    Jun 17 2026 17:55:39    Jun 17 2026 18:25:36
202205151200        Done    Jun 17 2026 17:55:39    Jun 17 2026 21:05:39
202205151800        Done    Jun 17 2026 17:55:39    Jun 17 2026 21:05:39

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/pr5011/RUNTESTS/EXPDIR/C96C48mx500_S2SW_cyc_gfs_ufs2m ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Jun 17 2026 17:55:20    Jun 17 2026 18:15:19
202112201800        Done    Jun 17 2026 17:55:20    Jun 17 2026 21:30:45
202112210000        Done    Jun 17 2026 17:55:20    Jun 17 2026 21:55:44
202112211800        Done    Jun 17 2026 18:20:30    Jun 17 2026 22:05:37

@barlage

barlage commented Jun 18, 2026

Copy link
Copy Markdown

@DavidHuber-NOAA The ufs-weather-model production/GFS.v17 branch has committed @d4b7b56 to include updates for this 2-m dewpoint issue. Please sync your branch accordingly. Note: @barlage would like to keep these 2-m dewpoint-related changes in the dev/gfs.v17 branch and not sync them to the develop branch, as they are intended only for the GFS v17 implementation.

I would like to note that I don't believe it was just me who wants to keep these changes isolated. It was a group decision. This fix is specific to concerns identified in the GFS v17 field evaluation. A more general fix is being worked on in the model, which would make these changes obsolete, hence the choice to not need to revert them in the near future.

@barlage barlage left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I traced the code in the multiple pathways that were changed and everything looks correct. Testing at coarse and full resolution produced the expected impacts.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully label Jun 18, 2026
@DavidHuber-NOAA DavidHuber-NOAA merged commit e42f47a into NOAA-EMC:dev/gfs.v17 Jun 18, 2026
7 checks passed
@WenMeng-NOAA

Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA The ufs-weather-model production/GFS.v17 branch has committed @d4b7b56 to include updates for this 2-m dewpoint issue. Please sync your branch accordingly. Note: @barlage would like to keep these 2-m dewpoint-related changes in the dev/gfs.v17 branch and not sync them to the develop branch, as they are intended only for the GFS v17 implementation.

I would like to note that I don't believe it was just me who wants to keep these changes isolated. It was a group decision. This fix is specific to concerns identified in the GFS v17 field evaluation. A more general fix is being worked on in the model, which would make these changes obsolete, hence the choice to not need to revert them in the near future.

@barlage Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants