Skip to content

(develop) Add marine LETKF to workflow#4789

Open
AndrewEichmann-NOAA wants to merge 24 commits into
NOAA-EMC:developfrom
AndrewEichmann-NOAA:feature/revive_marine_letkf_workflow
Open

(develop) Add marine LETKF to workflow#4789
AndrewEichmann-NOAA wants to merge 24 commits into
NOAA-EMC:developfrom
AndrewEichmann-NOAA:feature/revive_marine_letkf_workflow

Conversation

@AndrewEichmann-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds option DOLEKTF_OCN_INC that runs the marine LEKTF, recenters the increments around the deterministic analysis, and initializes the ensemble with the results

Resolves #5025
Also resolves #4223

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))

    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO

  • Does this change require a documentation update? NO

  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Cycled on Ursa with C384mx025_hybAOWCDA (DOLEKTF_OCN_INC and DOLEKTF_OCN both enabled and disabled) and C48mx500_3DVarAOWCDA

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@DavidHuber-NOAA DavidHuber-NOAA changed the title Add marine LETKF to workflow (develop) Add marine LETKF to workflow Apr 30, 2026
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review June 16, 2026 18:10

@shlyaeva shlyaeva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @AndrewEichmann-NOAA! I've reviewed code changes and they look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to recenter marine LETKF increments and use to initialize ensemble marineanlfinal should depend on marineanlletkf

2 participants