Merge dev/sfs into develop#4763
Open
NeilBarton-NOAA wants to merge 287 commits into
Open
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
note spackstack 2.1 has been install on the machines and the modules for atmos_post, which uses spackstack2.1 have been separated from the run modules. Hence #4733 is satisfied. I'm removing this from draft mode. There are a lot of changes, and I'm happy to meet to discuss how to proceed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| @@ -0,0 +1,17 @@ | |||
| {% set cycle_YMDH = current_cycle | to_YMDH %} | |||
Contributor
There was a problem hiding this comment.
are these specific to SFS? If so I'd recommend titling them _sfs instead of _mem - which could be an enkf member, gefs or sfs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft PR to show changes between dev/sfs and develop. dev/sfs is tested bi-weekly(ish) with the CI test and code standards.
Any comments in changes is appreciated with the goal of easing the merge to develop
Major GW-updates include:
Postprocessing for SFS products is dependent on #4733
Type of change
Change characteristics
How has this been tested?
CI tests run on ursa and c6
Checklist