Skip to content

Merge dev/sfs into develop#4763

Open
NeilBarton-NOAA wants to merge 287 commits into
developfrom
dev/sfs
Open

Merge dev/sfs into develop#4763
NeilBarton-NOAA wants to merge 287 commits into
developfrom
dev/sfs

Conversation

@NeilBarton-NOAA

@NeilBarton-NOAA NeilBarton-NOAA commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Description

Draft PR to show changes between dev/sfs and develop. dev/sfs is tested bi-weekly(ish) with the CI test and code standards.

Any comments in changes is appreciated with the goal of easing the merge to develop

Major GW-updates include:

  • SFS products
  • SFS post jobs to create products
  • SFS initialization with GFSv17
  • Model Namelist Changes for SFS

Postprocessing for SFS products is dependent on #4733

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update?
  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

CI tests run on ursa and c6

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@NeilBarton-NOAA

Copy link
Copy Markdown
Contributor Author

note spackstack 2.1 has been install on the machines and the modules for atmos_post, which uses spackstack2.1 have been separated from the run modules. Hence #4733 is satisfied.

I'm removing this from draft mode. There are a lot of changes, and I'm happy to meet to discuss how to proceed.

@DavidHuber-NOAA

NeilBarton-NOAA and others added 2 commits May 22, 2026 14:35
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@NeilBarton-NOAA NeilBarton-NOAA marked this pull request as ready for review May 22, 2026 18:36
Comment thread dev/parm/config/gfs/config.cleanup Outdated
@@ -0,0 +1,17 @@
{% set cycle_YMDH = current_cycle | to_YMDH %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these specific to SFS? If so I'd recommend titling them _sfs instead of _mem - which could be an enkf member, gefs or sfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants