Implement functions and classes in ngen to produce Catchment output netcdfs [NGWPC-10597]#177
Draft
sivasankkar wants to merge 8 commits into
Draft
Implement functions and classes in ngen to produce Catchment output netcdfs [NGWPC-10597]#177sivasankkar wants to merge 8 commits into
sivasankkar wants to merge 8 commits into
Conversation
cae217c to
61be6c6
Compare
commit 971c830 Author: siva.selvanathan Added checks for MPI and output variables in realization to prevent NetCDF creation. Added appropriate log messages. commit b82797b Author: siva.selvanathan Date: Mon Jan 26 21:46:41 2026 -0500 Added a couple of macro If blocks to prevent attempts to write to a single NetCDF in parallel fashion. commit cf5e694 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Mon Jan 26 14:52:17 2026 -0500 Included num_proc if clause to prevent MPI Barrier being called for a single process. Also, removed an unused function from the test class. commit f4b8819 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Mon Jan 26 11:29:36 2026 -0500 Unit tests for netcdf creators. This build does not support MPI functionality. commit fff50aa Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Tue Jan 13 21:18:32 2026 -0500 Added dependent libraries to test_ngen_simulation for a successful build. commit 915c0c3 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Tue Jan 13 17:24:56 2026 -0500 Changes made to enable MPI for netcdf writing. commit fc5eec5 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Mon Jan 12 09:19:57 2026 -0500 Made changes to enable MPI for catchment NetCDF creation. Build is still failing. commit 43fb963 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Sun Jan 11 21:11:14 2026 -0500 Added pybind include directory to check pipeline build commit 53f7022 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Sun Jan 11 17:14:34 2026 -0500 NetCDF for catchment outputs funcitonality implemented. commit 74a624a Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Wed Dec 24 09:17:12 2025 -0500 Included proper headers and target directories to CMakeFile to make the program compilable. commit 3dcac1a Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Tue Dec 23 14:26:04 2025 -0500 Removed all class variables and constructor implementation for NetCDFCreator. Currently, the code is skeletal with the focus on getting a successful compile. commit 4358f6a Merge: 6fcb180 b44c038 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Thu Dec 18 13:44:24 2025 -0500 Merge branch 'ssn_9011_netcdf_for_catchments' of https://github.com/NGWPC/ngen into ssn_9011_netcdf_for_catchments commit 6fcb180 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Thu Dec 18 12:26:03 2025 -0500 first commit with new netcdfcreator class commit b44c038 Author: siva.selvanathan <sselvanathan_IE@Dewberry.com> Date: Thu Dec 18 12:26:03 2025 -0500 first commit with new netcdfcreator class
…s updates with logger.
… changes to NgenSimulation and NetCDF Data provider. The old C++ class NetCDFCreator hasn't been removed yet.
1f1199b to
f84be25
Compare
…table fails due to shared library issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable functionality in ngen to write all catchment outputs to a netcdf file for non-MPI ngen runs. This PR is created following NGWPC-9011 PR (#106). However, that didn't make it into development because it remained in draft. We squashed all earlier commits and rebased with ngen development for this PR. This functionality does not work on MPI runs.
Additions
Removals
Changes
get_output_variable_unitsandset_output_variable_unitsfunction to obtain the output variable units to write to netcdf attributes.Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support