Report template version 4.5 and natural gas combustion test case#9
Open
dt-woods wants to merge 20 commits into
Open
Report template version 4.5 and natural gas combustion test case#9dt-woods wants to merge 20 commits into
dt-woods wants to merge 20 commits into
Conversation
- Added function to read scenarios from DS files (only reads specific file in data folder right now) - Edited Markdown block in create_markdown_report function to hard code some information
Edited create_report_markdown and empty_markdown functions.
Move scrollable table styles to CSS file. For test case, read the external parameter table (there's a separate function that created it and just hard-code reading it during fetch data). Clean up some of the scrolling divs and try to link them all to the CSS for convenience. New style for parameter table with fixed first column. Still to reorganize the sections.
Including some instructions in a few sections
…mplate into up-report-ver2
make default tables have a static header row; set a max table height for the horizontal scroll table with static first column; make definition terms bold
Create a product systems class property list (easier to grab UUID). Add HTML page title to convert. Provide a method to write blank MD template in save_markdown.
Consistent versioning with respect to the pprevious versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request presents updates to the v4 report template as defined in NetlOlcaReport class. It includes a new layout and additional metadata fields. The new empty template includes instructions for completion, and there is now a method of writing the empty template to file without requiring an openLCA database connection. This version is marked as 'beta' due to some hard-coded methods and references to external datasets that are specific to the test case.