Distiller metadata updater#530
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 889f754db1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
swelborn
approved these changes
Jan 23, 2026
swelborn
approved these changes
Jan 23, 2026
…ate if we have both C12 and phi12.
ercius
force-pushed
the
distiller_metadata_updater
branch
from
January 23, 2026 19:18
f27f547 to
52a71dc
Compare
swelborn
approved these changes
Jan 23, 2026
swelborn
approved these changes
Jan 23, 2026
| } | ||
| updated_scan = add_metadata(distiller_scan_id, metadata_payload) | ||
| logger.info(f"Updated Distiller scan metadata: {updated_scan.metadata}") | ||
| else: |
Member
There was a problem hiding this comment.
For future reference if you have something like this you can instead return early, and you reduce the nesting by 1 which makes more readable code
if not C12_magnitude or not C12_angle:
logger.info("C12 Magnitude or phi12 not found in metadata.")
return
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will write astigmatism results (C12 and phi12) from the quantem-direct-ptycho into the metadata of the correct Distiller scan.