Skip to content

Adopt the approver's approval in NCodeGroup/Buffers and NCodeGroup/PropertyBag #396

Closed

Description

@polewskm

What remains: NCodeGroup/Buffers and NCodeGroup/PropertyBag submit NCode Review's approval as the NCode Review Approver and require it (ADR-0036, v0.111.0). Both already hold NCODE_REVIEW_APPROVER_PRIVATE_KEY in their code-review environment, and the approver app is installed on both.

For each:

  • Update to project-template v0.111.0 through its template-update issue, so .github/workflows/code-review.yml pins NCodeGroup/code-review v1.5.0 or later and passes approver-private-key: ${{ secrets.NCODE_REVIEW_APPROVER_PRIVATE_KEY }} in the review job. code-review.yml is the project's, so the update only prints what it lacks.
  • Run tools/Set-RepositoryBaseline.ps1 -Repo <name>, which then requires one approval, of the last push.
  • Check that the next clean review is approved by ncode-review-approver[bot] and meets the required approval.

NCodeGroup/code-review has adopted it (NCodeGroup/code-review#235, and its ruleset requires one approval, of the last push).

Found while planning #385 #381 #383 #382 #386; it landed in https://github.com/NCodeGroup/project-template/releases/tag/v0.96.0. Refs #460.

Activity

  1. changed the title [-]Adopt the approval in NCodeGroup/Buffers and NCodeGroup/code-review[/-] [+]Adopt the approver's approval in NCodeGroup/Buffers and NCodeGroup/PropertyBag[/+] on Nov 21, 2026
  2. polewskm commented on Nov 21, 2026

    @polewskm
    CollaboratorAuthor

    Rewritten to describe only what remains. NCode Review's own approval never met a required approval (#460), so adopting the approval means the approver app since v0.111.0 (ADR-0036). NCodeGroup/code-review has it. PropertyBag joins Buffers here, since the baseline requires the approval wherever the approver is set up.


    Generated by Claude Code

  3. polewskm commented on Nov 21, 2026

    @polewskm
    CollaboratorAuthor

    Done in both repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    follow-upWork a plan found and did not do

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions