You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Adopt the approver's approval in NCodeGroup/Buffers and NCodeGroup/PropertyBag #396
What remains: NCodeGroup/Buffers and NCodeGroup/PropertyBag submit NCode Review's approval as the NCode Review Approver and require it (ADR-0036, v0.111.0). Both already hold NCODE_REVIEW_APPROVER_PRIVATE_KEY in their code-review environment, and the approver app is installed on both.
For each:
Update to project-template v0.111.0 through its template-update issue, so .github/workflows/code-review.yml pins NCodeGroup/code-review v1.5.0 or later and passes approver-private-key: ${{ secrets.NCODE_REVIEW_APPROVER_PRIVATE_KEY }} in the review job. code-review.yml is the project's, so the update only prints what it lacks.
Run tools/Set-RepositoryBaseline.ps1 -Repo <name>, which then requires one approval, of the last push.
Check that the next clean review is approved by ncode-review-approver[bot] and meets the required approval.
NCodeGroup/code-review has adopted it (NCodeGroup/code-review#235, and its ruleset requires one approval, of the last push).
changed the title [-]Adopt the approval in NCodeGroup/Buffers and NCodeGroup/code-review[/-][+]Adopt the approver's approval in NCodeGroup/Buffers and NCodeGroup/PropertyBag[/+]on Nov 21, 2026
Rewritten to describe only what remains. NCode Review's own approval never met a required approval (#460), so adopting the approval means the approver app since v0.111.0 (ADR-0036). NCodeGroup/code-review has it. PropertyBag joins Buffers here, since the baseline requires the approval wherever the approver is set up.
NCodeGroup/Buffers and NCodeGroup/PropertyBag are on project-template v0.111.0. Their code-review.yml pins NCodeGroup/code-review v1.5.0 and passes approver-private-key.
Each repository's Protect main ruleset requires one approval, of the last push.
Activity
[-]Adopt the approval in NCodeGroup/Buffers and NCodeGroup/code-review[/-][+]Adopt the approver's approval in NCodeGroup/Buffers and NCodeGroup/PropertyBag[/+]polewskm commentedon Nov 21, 2026
Rewritten to describe only what remains. NCode Review's own approval never met a required approval (#460), so adopting the approval means the approver app since v0.111.0 (ADR-0036). NCodeGroup/code-review has it. PropertyBag joins Buffers here, since the baseline requires the approval wherever the approver is set up.
Generated by Claude Code
polewskm commentedon Nov 21, 2026
Done in both repositories.
code-review.ymlpins NCodeGroup/code-review v1.5.0 and passesapprover-private-key.ncode-review-approver[bot]approved the last push of Grant raise-baseline.yml the permissions it declares, so publishing starts Buffers#127, Raise the package validation baseline to 5.5.0 Buffers#129 and Null check in DefaultPropertyBagScope constructor PropertyBag#55. GitHub marked each pull request approved, so the required approval was met.