Repository navigation
Conversation
… band's exception
…er, the team-chain resolver and the team broadcast handler
…actory and access-token tests
…e endpoint handler tests
There was a problem hiding this comment.
🤖 NCode Review at 4026dc3: 6 new findings on the changed lines.
|
Superseded by the review at 5acb9e7. |
There was a problem hiding this comment.
Approved at 4026dc3: no blocker or should-fix finding remains.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 95.94% 95.93% -0.01%
==========================================
Files 2205 2205
Lines 99612 99611 -1
Branches 202 202
==========================================
- Hits 95570 95566 -4
- Misses 4042 4045 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
/review Generated by Claude Code |
|
Superseded by the review at 3d6bfd9. |
There was a problem hiding this comment.
Approved at 5acb9e7: no blocker or should-fix finding remains.
|
Autopilot: this pull request is ready to merge as far as this run can tell.
Generated by Claude Code |
There was a problem hiding this comment.
Approved at 3d6bfd9: no blocker or should-fix finding remains.
🤖 Review completeVerdict: ✅ Approve — Nothing in this pull request's own changes differs from the last review at 5acb9e7, so nothing was reviewed again. No further findings above nits. Approval: Approved — no blocker or should-fix finding remains. 0 reviewers run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.00 on Amazon Bedrock, 7s, at 3d6bfd9. (how to interact) |
Every Microsoft.Extensions, ASP.NET Core and EF Core package, the Npgsql EF Core provider and the .NET release's System packages resolve on the target framework's band at one patch, 10.0.15 ([ADR-1519](
docs/decisions/1519-every-microsoft-extensions-aspnet-core-and-ef-core-package-is-on-the-target-frameworks-release-band.md)). TheRequireRuntimeBandtarget inDirectory.Build.targetsfails a project that resolves one at another major, with build-guard fixture tests. Dependabot holds their major version.The only package off the band is the
Microsoft.Extensions.DependencyInjection(.Abstractions)pair. NCode.PropertyBag's floor holds it at 11.0.0, andRuntimeBandExceptionsnames it as the one exception, beside a comment that links #895. #895 stays open until NCodeGroup/PropertyBag ships a release on the 10.0 band.The server registers no
IPropertyBagFactory. Every operation with nothing to inherit starts fromnew PropertyBagDictionary(), andBannedSymbols.PropertyBag.txtbans the property-bag factories in every project. ADR-1518, ADR-1069, ADR-1127, the C# conventions, GOVERNANCE.md and the changelog describe this.Protected paths changed:
.dockerignore
.github/dependabot.yml
.github/instructions/csharp-production.instructions.md
Directory.Build.targets
Directory.Packages.props
build/dod.ps1
build/tests/build-guards.tests.ps1
Closes #896
Refs #895
Generated by Claude Code