Skip to content

build: keep one runtime band and construct property bags directly - #902

Open
polewskm wants to merge 19 commits into
mainfrom
claude/confident-cerf-44sgmj
Open

polewskm wants to merge 19 commits into
mainfrom
claude/confident-cerf-44sgmj

Conversation

@polewskm

Copy link
Copy Markdown
Contributor

Every Microsoft.Extensions, ASP.NET Core and EF Core package, the Npgsql EF Core provider and the .NET release's System packages resolve on the target framework's band at one patch, 10.0.15 ([ADR-1519](docs/decisions/1519-every-microsoft-extensions-aspnet-core-and-ef-core-package-is-on-the-target-frameworks-release-band.md)). The RequireRuntimeBand target in Directory.Build.targets fails a project that resolves one at another major, with build-guard fixture tests. Dependabot holds their major version.

The only package off the band is the Microsoft.Extensions.DependencyInjection(.Abstractions) pair. NCode.PropertyBag's floor holds it at 11.0.0, and RuntimeBandExceptions names it as the one exception, beside a comment that links #895. #895 stays open until NCodeGroup/PropertyBag ships a release on the 10.0 band.

The server registers no IPropertyBagFactory. Every operation with nothing to inherit starts from new PropertyBagDictionary(), and BannedSymbols.PropertyBag.txt bans the property-bag factories in every project. ADR-1518, ADR-1069, ADR-1127, the C# conventions, GOVERNANCE.md and the changelog describe this.

Protected paths changed:
.dockerignore
.github/dependabot.yml
.github/instructions/csharp-production.instructions.md
Directory.Build.targets
Directory.Packages.props
build/dod.ps1
build/tests/build-guards.tests.ps1

Closes #896
Refs #895


Generated by Claude Code

@polewskm
polewskm deployed to code-review November 22, 2026 02:44 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 4026dc3: 6 new findings on the changed lines.

Comment thread build/dod.ps1 Resolved
Comment thread .github/dependabot.yml Resolved
@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at 5acb9e7.

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 4026dc3: no blocker or should-fix finding remains.

@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   95.94%   95.93%   -0.01%     
==========================================
  Files        2205     2205              
  Lines       99612    99611       -1     
  Branches      202      202              
==========================================
- Hits        95570    95566       -4     
- Misses       4042     4045       +3     
Flag Coverage Δ
dotnet 95.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@ncode-review

ncode-review Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Superseded by the review at 3d6bfd9.

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 5acb9e7: no blocker or should-fix finding remains.

@polewskm polewskm self-assigned this Nov 22, 2026

Copy link
Copy Markdown
Contributor Author

Autopilot: this pull request is ready to merge as far as this run can tell.


Generated by Claude Code

@polewskm
polewskm marked this pull request as ready for review November 22, 2026 03:26
@polewskm
polewskm deployed to code-review November 22, 2026 03:26 — with GitHub Actions Active
@polewskm
polewskm enabled auto-merge November 22, 2026 03:26

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 3d6bfd9: no blocker or should-fix finding remains.

@ncode-review

ncode-review Bot commented Nov 22, 2026

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Nothing in this pull request's own changes differs from the last review at 5acb9e7, so nothing was reviewed again. No further findings above nits.

Approval: Approved — no blocker or should-fix finding remains.

0 reviewers run — 0 findings (run details)

Reviewer Model Findings Top

Trial: findings are posted as review threads and in the check run. $0.00 on Amazon Bedrock, 7s, at 3d6bfd9. (how to interact)

This branch was successfully deployed

1 active deployment
code-review — 3d6bfd98 Deployed Nov 22, 2026 by polewskm via review #2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve the unused property-bag factory registration

1 participant