Repository navigation
docs: write Best Practices documents and pass NCode Review's approval inputs - #901
Merged
Merged
Conversation
… match the records
…ailed client authentications
There was a problem hiding this comment.
🤖 NCode Review at 3a30be1: 3 new findings on the changed lines.
|
Superseded by the review at eae0431. |
This was referenced Nov 22, 2026
Contributor
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 3a30be1: 2 hunks in 2 files and changes taken back in 2 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.06 on Amazon Bedrock, 11s, at eae0431. (how to interact) 📋 OutcomesMerged at eae0431: 2 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
polewskm
marked this pull request as ready for review
November 22, 2026 02:18
polewskm
enabled auto-merge
November 22, 2026 02:19
Contributor
Author
|
Autopilot: this pull request is ready to merge as far as this run can tell.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCode Review pins v1.4.2, the newest release past the three-day cooldown, and passes
approve: trueand the NCode Review Approver's key, so a review that leaves no blocker or should-fix finding open approves the pull request; v1.5.0 and later submit that approval as the Approver, which can meet a required approval.docs/assurance-case.md,docs/architecture.mdandROADMAP.mddescribe this family: its twelve security requirements, threat model, design principles, the weaknesses it counters, evidence, components, design rules and direction, each claim citing the decision record that decides it..vscode/settings.jsonis project-owned through theproject_owned_filesanswer, andAGENTS.mdand the changelog catalog say so.#898 and #899 stay open for the work outside the repository's files: the v1.5.0 pin once past its cooldown, the approver's key and the
mainruleset's required approval (#898), and/best-practiceswith the bestpractices.dev registration (#899).Protected paths changed:
.copier-answers.yml
.github/workflows/code-review.yml
AGENTS.md
Closes #900
Partly completes #898
Partly completes #899