Repository navigation
Move the review workflow to code-review v0.3.0, which fetches the pull request itself - #18
Conversation
…l request itself The engine fetches the pull request's head from v0.3.0 on, so the workflow drops its checkout of it, and CodeQL no longer reports the workflow.
There was a problem hiding this comment.
🤖 NCode Review at 143bde2: 1 new finding on the changed lines.
🤖 Review completeVerdict: 💬 Comment — The PR moves the review workflow to NCodeGroup/code-review v0.3.0, which fetches the pull request itself, so the workflow no longer checks out the PR head. It also updates the header comment to say this. The change is small and makes the design simpler: the pull_request_target job no longer puts untrusted head code on the runner, which lowers risk. The only open point is a pinning question that the file's documented convention already addresses. 4 reviewers run — 1 finding (run details)
Skipped: api-compat, architecture, completeness, correctness, data-model, infrastructure, intent, performance, tests Findings
Trial: findings are posted as review threads and in the check run. $0.17 on Amazon Bedrock, 33s, at 143bde2. (how to interact) |
Moves the review workflow to
NCodeGroup/code-review@v0.3.0and removes its second checkout, the one of the pull request's head.From v0.3.0 the engine fetches the exact commit itself, after it has decided to review, with git started without configuration, hooks or a credential helper. The workflow no longer checks out untrusted code in a privileged context, so CodeQL stops reporting it: the two alerts on this file ("checkout of untrusted code in a privileged context" and its TOCTOU variant) were accepted risks, dismissed by hand, and came back on every repository that adopted the bot.
Nothing else changes: the triggers, the
code-reviewenvironment, the secrets, the permissions (the job token still hascontents: read, which the engine uses for the fetch) and the default-branch checkout for the conventions. A/reviewafter this merges is the first run of v0.3.0 here.