Split smoking/mortality parameter bundles and CRAN review fixes#27
Draft
john-clarke wants to merge 13 commits into
Draft
Split smoking/mortality parameter bundles and CRAN review fixes#27john-clarke wants to merge 13 commits into
john-clarke wants to merge 13 commits into
Conversation
Replace single-zip load_params with smoking_url and mortality_url, merge shg-params params/ layout into engine paths, and track smok_params_source, mort_params_source, and mort_params_type on SHGInterface (6.5.3-1.0.1). Co-authored-by: Cursor <cursoragent@cursor.com>
Portable YAML and shg_apply_config require smok_params_source and mort_params_source; reject removed params_bundle_source and params_mortality keys. Co-authored-by: Cursor <cursoragent@cursor.com>
Ship shg-params-style smoking and mortality zips plus a script to regenerate them from the legacy combined fixture. Co-authored-by: Cursor <cursoragent@cursor.com>
Update README, config guides, NEWS, and roxygen-generated man pages for the new config keys and load_params API. Co-authored-by: Cursor <cursoragent@cursor.com>
Point portable workflow and sample configs at separate smok and mort test zips. Co-authored-by: Cursor <cursoragent@cursor.com>
Matsumoto and Nishimura (Mersenne Twister) and L'Ecuyer (RngStream) are acknowledged per CRAN policy for third-party code in the simulation engine. Co-authored-by: Cursor <cursoragent@cursor.com>
Rewrites the one-paragraph summary without a leading "This package" opener, documents core functionality, and adds DOIs for the SHG chapter and RNG sources. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds durable roxygen in R/shg-rcpp-docs.R and regenerates help pages for SHGInterface, simulation methods, and config helpers flagged in review. Co-authored-by: Cursor <cursoragent@cursor.com>
Replaces dontrun with bundled extdata examples or donttest, removes commented-out example code, and drops library() calls from help examples. Co-authored-by: Cursor <cursoragent@cursor.com>
Add cph alongside ctb for Matsumoto, Nishimura, and L'Ecuyer with comments pointing to the embedded source files. Remove donttest wrappers; bundled extdata examples finish in under five seconds on check hardware. Co-authored-by: Cursor <cursoragent@cursor.com>
Add shg-params-style bundled-smok.zip and bundled-mort.zip under inst/extdata/2018, point demos at system.file paths, and rebuild those zips when refreshing the NHIS csv-partial. Co-authored-by: Cursor <cursoragent@cursor.com>
Expand ?shg_run value text for the four-component attach_run_info list, cross-link from Rcpp sim methods, keep useConfig examples only in shg-rcpp-docs.R, and drop duplicate @return/@examples from wrapper.cpp. Co-authored-by: Cursor <cursoragent@cursor.com>
Document shg_params_cache_dir and shg_clear_params_cache return values, regenerate Rd, and record the exported-\value requirement in AGENTS.md. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smok_params_source,mort_params_source,mort_params_type) instead of a single combined bundle; reject legacy combined-bundle configs with clear errors.shg_run, and tests (split fixtures + updated testthat coverage).DESCRIPTION,Authors@Rctb/cphfor vendored Mersenne Twister and RngStream code,\valuedocumentation, and runnable examples using bundledextdata.Test plan
testthat::test_local(..., load_package = "installed")— 392 passed, 0 failedrcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning")— 0 errors, 0 warningsMade with Cursor