add satellite filtering options#433
Draft
blychs wants to merge 2 commits into
Draft
Conversation
rrbuchholz
approved these changes
Jun 24, 2026
rrbuchholz
left a comment
rrbuchholz
left a comment
Collaborator
There was a problem hiding this comment.
Looks like a good start to me!
Collaborator
|
Not sure why issues are happening in the CI test? Seems to maybe be related to AERONET? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding as draft because it still needs some testing.
This PR is a bit ugly: it uses our existing capabilities to add all of the filtering, masking and summing capabilities to satellites, by using some ugly copy-paste and looping to deal with the possibility of having dictionaries instead of a dataset. I believe this can be easily superseded when we move to Datatrees.
I included here #432 , since I think it will be merged faster and this should avoid merge conflicts.