This repository was archived by the owner on May 21, 2026. It is now read-only.
perf: optimize TRR writer with batched header writes#22
Merged
Conversation
…unks - writeHeader: pack all 15 fields into a single 84-byte buffer and write in one call instead of 16 individual writeInt/writeFloat calls - writeFloatsBulk: increase chunk size from 1024 to 4096 floats (16KB) to reduce write syscalls - Box matrix: flatten to 1D array and write via writeFloatsBulk
…flicts - Remove validation_test from main test step (was causing parallel file conflicts with the same tmp paths) - Add separate `zig build validate` step in CI - Validation tests still run in CI, just sequentially after unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These are incremental I/O optimizations. The TRR writer already achieves ~900 MB/s (read+write combined), which is ~4x faster than mdtraj's C reader. The bottleneck is now the read side, not the write side.
Test plan