Make bare file URLs actually file: URLs#131
Open
brianjmurrell wants to merge 2 commits into
Open
Conversation
QUrl will mangle the content of a string, in particular it will convert the first letter to lower case if the string contains a colon. So properly form filenames as file URLs by prefixing them with file:
When converting a string to a URL, only make it a file:// URL if it does not already have a scheme.
Member
|
Is there a real world use case that this PR addresses? |
Contributor
Author
|
There most certainly would have been. I wouldn't have wasted time on figuring out the problem and cooking up a fix if there were not. But I have not used MythTV in probably years now. Feel free to close and discard this if you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUrl will mangle the content of a string, in particular it will convert the first letter to lower case if the string contains a colon.
So properly form filenames as file URLs by prefixing them with file:
Tracked in https://code.mythtv.org/trac/ticket/13006