Skip to content

feat(mediabar): Fallback to movie and tv libraries if no profile resolved#133

Merged
RadicalMuffinMan merged 4 commits into
Moonfin-Client:masterfrom
mattsigal:feature/mediabar-fallback
May 30, 2026
Merged

feat(mediabar): Fallback to movie and tv libraries if no profile resolved#133
RadicalMuffinMan merged 4 commits into
Moonfin-Client:masterfrom
mattsigal:feature/mediabar-fallback

Conversation

@mattsigal

Copy link
Copy Markdown
Contributor

Pull Request Template

Summary

Fallback to movie and tv libraries with exactly 5 items if the resolved profile is null.

Related Issues

Fixes media bar pull logic.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Introduced a fallback state check (isFallback) in MoonfinController.GetMediaBarItems when settings profile is null.
  • Overrode settings to force source type to "library", targeted libraries to all libraries (null), and item limit to 5.
  • Reused existing server-side random querying and image/rating resolution logic.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code (Server Plugin API)

Testing

Tested server endpoint behavior locally. Detailed validation to be performed once compiled into a test plugin release.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why): Verified via static analysis and code review. Detailed testing will occur on the target test environment.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

mattsigal added 2 commits May 29, 2026 16:43
…lved

If the plugin resolved settings query returns no user profile (or encounters an error loading user settings), the media bar now falls back to pulling exactly 5 items from the movies or series libraries.
- Forces MediaBar source type to library and item count limit to 5 when resolving fallback.
- Bypasses configured library selections to query all user-visible movies and series.
- Ensures all clients (TV, Mobile, Web) get consistent fallback behavior automatically.
@github-actions

Copy link
Copy Markdown

Build Successful

The plugin compiled successfully against .NET 8 / Jellyfin 10.10.0.

Property Value
Commit 223cb70
Workflow Build #77

@RadicalMuffinMan RadicalMuffinMan merged commit 2926a34 into Moonfin-Client:master May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants