Refine metadata container rounding and singular/plural headers#554
Merged
RadicalMuffinMan merged 1 commit intoJun 16, 2026
Merged
Conversation
* Pass dynamic BorderRadius to _MetadataGroupCell to prevent rounded corner artifacts on contiguous focus borders. * Implement dynamic singular/plural labels (Director vs Directors, Writer vs Writers) based on item list length. * Add directors (plural) and writer (singular) localization template strings. * Run flutter gen-l10n to regenerate localization code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Refines the visual corners of the details page metadata row cells (Director / Writers / Studio) to align with the outer container boundary when focused, and implements dynamic singular/plural headers based on items count.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
_MetadataGroupCellto accept a customborderRadius. We calculate this dynamically based on its position in the row:BorderRadius.zero)."directors"(plural) and"writer"(singular) translation keys inapp_en.arb. Updated the header selection logic so that:Director/Writer.Directors/Writers(plural).Platform
Testing
Describe how this change was tested.
Tested on emulator / simulator
Tested on physical device
Manual testing completed - tested on Windows Desktop
Not tested (explain why):
Ran
flutter gen-l10nand verified that localizations compile cleanly.Ran
flutter analyzeto ensure there are no compilation warnings or errors in the project.Successfully compiled the Windows client using
build-windows.ps1to test locally.Test Steps
Screenshots (if applicable)
Checklist