Skip to content

Refine metadata container rounding and singular/plural headers#554

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/details-containers-refinement
Jun 16, 2026
Merged

Refine metadata container rounding and singular/plural headers#554
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/details-containers-refinement

Conversation

@mattsigal

@mattsigal mattsigal commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Refines the visual corners of the details page metadata row cells (Director / Writers / Studio) to align with the outer container boundary when focused, and implements dynamic singular/plural headers based on items count.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Dynamic Corner Rounding on Focus: Modified _MetadataGroupCell to accept a custom borderRadius. We calculate this dynamically based on its position in the row:
    • Left cell rounds only the left corners (radius 11).
    • Right cell rounds only the right corners (radius 11).
    • Middle cell remains rectangular (BorderRadius.zero).
    • This perfectly aligns the focused highlight borders with the shared inner walls and outer borders, eliminating visual rounding overlap artifacts.
  • Dynamic Singular/Plural Headers: Defined "directors" (plural) and "writer" (singular) translation keys in app_en.arb. Updated the header selection logic so that:
    • If a title has exactly 1 director/writer, it displays Director / Writer.
    • If it has multiple, it displays Directors / Writers (plural).
    • Any missing translations in other locales automatically fall back to the new English defaults.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator

  • Tested on physical device

  • Manual testing completed - tested on Windows Desktop

  • Not tested (explain why):

  • Ran flutter gen-l10n and verified that localizations compile cleanly.

  • Ran flutter analyze to ensure there are no compilation warnings or errors in the project.

  • Successfully compiled the Windows client using build-windows.ps1 to test locally.

Test Steps

  1. Navigate to the detail page of a media item with 1 director (e.g. "Director") and verify the label is singular.
  2. Navigate to the detail page of a media item with multiple directors/writers and verify the label is plural.
  3. Focus each metadata cell (Director, Writers, Studio) and verify that the highlighted borders follow the outer rounding perfectly with no gaps or overlapping rounded corners on the inner boundaries.

Screenshots (if applicable)

2026-06-16_08-57-16_moonfin Shield_Screenshot_2026-06-16_07-43-56

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

* Pass dynamic BorderRadius to _MetadataGroupCell to prevent rounded corner artifacts on contiguous focus borders.
* Implement dynamic singular/plural labels (Director vs Directors, Writer vs Writers) based on item list length.
* Add directors (plural) and writer (singular) localization template strings.
* Run flutter gen-l10n to regenerate localization code.
@RadicalMuffinMan
RadicalMuffinMan merged commit 3f7d58d into Moonfin-Client:main Jun 16, 2026
9 checks passed
@mattsigal
mattsigal deleted the feature/details-containers-refinement branch June 23, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants