Refine Home Screen Row Alignment and Media Bar Visibility for Expanded Home Rows#552
Merged
RadicalMuffinMan merged 1 commit intoJun 16, 2026
Conversation
- Pre-reserve vertical space for wrapped ratings in height checks when additional ratings are enabled, preventing description text cutoff on V2 rows. - Hide non-focused rows (both previous and next) when Expanded Home Rows (fullScreenRows) is active to prevent next-row titles from peeking at the bottom of the viewport. - Prevent Banner Media Bar from going transparent when navigation or content focus changes. - Ensure the full-display media bar correctly hides and scrolls off-screen on content focus, positioning the first row (My Media) correctly under the navigation overlay.
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The goal of Expanded Home Rows is to have 1 home row on screen at a time. However, this logic was based on set padding values and they stopped being accurate with certain combinations of UI Scale, Home Row Image Size, and the number of ratings a movie has. This PR refines the Home Screen row alignment, scroll target calculations, and Media Bar visibility logic when using Expanded Home Rows (
fullScreenRows) on TV/Desktop viewports.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
32.0 * desktopScale) to the measuredrowHeightduring scroll target calculations whenenableAdditionalRatingsis true. This prevents description text from being pushed off-screen or shifting when wrapped/two-row ratings load asynchronously._buildShiftedRowto hide all non-focused rows (both previous and next rows) whenfullScreenRowsis active. This prevents next-row titles from peeking or overlapping at the bottom of the viewport when a tall focused row is shifted up._mediaBarVisiblechanges to keep the Banner Media Bar visible when focus changes or moves down to content rows.0.0and correctly aligning the following row directly below the banner.defaultTop) for row 0 scroll targets. This slides the full-screen media bar completely off-screen and positionsMy Mediaperfectly under the navigation overlay with no blank screen.Platform
Testing
Describe how this change was tested.
Test Steps
My Mediakeeps the Banner visible at the top and positions the row below it.Latest CinemaorLatest Serials) are completely hidden and do not peek at the bottom of the screen.My Media, and verified the media bar scrolls off-screen cleanly, leaving no blank space.Screenshots (if applicable)
Include screenshots or recordings for UI changes.
DIFFERENT UI SCALING/POSTER SIZES
FULL SCREEN MEDIA BAR
HALF-SCREEN MEDIA BAR
MULTI-LINE RATINGS
Checklist