Skip to content

fix: resolve folder navigation and image display bugs in nested mixed libraries#498

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:bugfix/mixed-content-display
Jun 11, 2026
Merged

fix: resolve folder navigation and image display bugs in nested mixed libraries#498
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:bugfix/mixed-content-display

Conversation

@mattsigal

Copy link
Copy Markdown
Contributor

The one about Mixed Media

Summary

Resolves mixed content library nested folder browsing issues where Series/Seasons/Collections/Playlists are incorrectly navigated as folders and media items use landscape thumbs instead of portrait posters.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Modified FolderBrowseViewModel.isNavigableFolder to return false for Series, Season, BoxSet, and Playlist.
  • Modified FolderBrowseScreen._imageUrl to check folder navigation status. Prioritizes Primary poster images over Thumb landscape images for media items, and keeps Thumb prioritization for actual folders.
  • Fixed outdated assertions checking pref_audio_preference_split_v1 in audio_migration_test.dart (updated to v2) so that all tests pass.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Navigate into a nested folder containing movies and TV shows.
  2. Verify that movies and TV shows display using their portrait primary posters.
  3. Verify that clicking on a TV series navigates to the series detail screen rather than folder view.

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan

Copy link
Copy Markdown
Contributor

rebase on main

… libraries

- Exclude TV Series, Seasons, Collections, and Playlists from navigable folders in FolderBrowseViewModel.
- Clicking Series/Seasons/Collections/Playlists in folder views now opens their native detailed screens.
- Prioritize Primary (poster) images over Thumb (landscape) images in FolderBrowseScreen for media items.
- Fix audio migration unit test key mismatch (v1 -> v2) to ensure a clean test run.
@mattsigal mattsigal force-pushed the bugfix/mixed-content-display branch from a3d8fda to 228302d Compare June 11, 2026 20:01
@RadicalMuffinMan RadicalMuffinMan merged commit a615cb6 into Moonfin-Client:main Jun 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Mixed movies and shows folders don't display correctly

2 participants