Skip to content

fix: resolve disappearing chapter button in playback queues#497

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:bugfix/chapter-button-disappears
Jun 11, 2026
Merged

fix: resolve disappearing chapter button in playback queues#497
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:bugfix/chapter-button-disappears

Conversation

@mattsigal

@mattsigal mattsigal commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Resolves the issue where the OSD Chapter button disappears when playing series episodes via season, shuffle, or play queues.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Added Chapters field to metadata query arguments in lib/data/viewmodels/item_detail_view_model.dart, lib/di/modules/playback_module.dart, and lib/ui/screens/detail/item_detail_screen.dart (specifically for next-season, shuffle, and episode queues).
  • Fixed a broken preference key name check in unit tests (test/preference/audio_migration_test.dart: v1 -> v2) to allow all unit tests to pass cleanly.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Play episodes from a series detail screen using a play/shuffle queue.
  2. Verify that the Chapter button remains visible in the OSD player bar during playback and correctly populates the chapters list.
  3. Advance to the next episode and verify chapters are still successfully queried and visible.

Screenshots (if applicable)

Episode 1:
2026-06-11_08-00-17_moonfin

Episode 2:
2026-06-11_08-00-59_moonfin

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan

Copy link
Copy Markdown
Contributor

rebase on main

- Request Chapters field in episode details view model queries.
- Request Chapters field in episode details screen shuffle and play queue queries.
- Request Chapters field in next-season advance episode queries.
- Fix audio migration unit test key mismatch from v1 to v2.
@mattsigal mattsigal force-pushed the bugfix/chapter-button-disappears branch from ce819b8 to cc13f32 Compare June 11, 2026 19:59
@RadicalMuffinMan RadicalMuffinMan merged commit cdfa338 into Moonfin-Client:main Jun 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] [Fire TV] Chapter button disappears when "Next" and "Previous" buttons are visible

2 participants