fix(playback): bypass restrictive device profile query for external players#495
Merged
RadicalMuffinMan merged 1 commit intoJun 11, 2026
Conversation
RadicalMuffinMan
requested changes
Jun 11, 2026
RadicalMuffinMan
left a comment
RadicalMuffinMan
left a comment
Contributor
There was a problem hiding this comment.
remove audio_migration_test.dart, its already covered under #478
…layers - Replace internal player device profile query in ExternalPlayerHostScreen with a permissive profile representing typical external player codec and resolution capabilities (supporting AV1, HEVC, Dolby Vision, DTS, TrueHD, 4K, etc.). - Ensure user-defined maximum bitrate and maximum video resolution options are still respected. Closes Moonfin-Client#444
mattsigal
force-pushed
the
feature/external-player-4k-direct-stream
branch
from
b94c145 to
458eb76
Compare
Contributor
Author
|
Audio test removed :) Sorry about that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Resolves the issue where 4K HEVC / Dolby Vision video streams fail to launch in external players (e.g., Vimu, MX Player, VLC) and lock up the client app by triggering server-side transcoding. The solution is to bypass the restrictive internal player profile query in
ExternalPlayerHostScreenwith a permissive profile that advertises comprehensive 4K capabilities.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
ExternalPlayerHostScreenin external_player_host_screen.dart to build a fully permissive profile viaDeviceProfileBuilder.build(...)when launching an external player.pref_audio_preference_split_v2migration key instead of the stalev1key, resolving pre-existing test failures.Platform
Testing
Describe how this change was tested.
Test Steps
flutter analyzeto verify the modified code introduces no lints or warnings.flutter testto ensure all 42 unit tests pass successfully.Checklist