Skip to content

ui: remove focus overlay and use theme highlight color on genres#492

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/remove-genre-overlay
Jun 11, 2026
Merged

ui: remove focus overlay and use theme highlight color on genres#492
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/remove-genre-overlay

Conversation

@mattsigal

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Remove the focus color overlay from genre cards and ensure that the theme's accent/highlight color is used consistently for the focus border when browsing or viewing genres and their subitems.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • Refactored GenreGridCard to draw the focus glow (shadow) in the background rather than in the foreground, preventing the shadow from overlaying the poster design.
  • Updated LibraryBrowseScreen to override the card focus border color with the active theme's highlight color when browsing items in a genre.
  • Updated HomeScreen to override the card focus border color with the active theme's highlight color for items in the home screen's genres row.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed: Windows
  • Not tested (explain why):

Test Steps

  1. Launch the app and go to the "All Genres" page or any genre sub-list.
  2. Focus on a genre grid card (like "Martial Arts"). Verify that the pink highlight border is drawn in the foreground on Neon Pulse, and that the glow shadow is rendered in the background rather than overlaying the card image.
  3. Open a genre (e.g. "Martial Arts") to view its subitems (movies or shows). Focus on a media card and verify that the border highlights using the active theme's highlight color (e.g. Pink on Neon Pulse) without any overlay.

Screenshots (if applicable)

2026-06-11_00-28-37_moonfin

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

- Refactor GenreGridCard to draw the focus glow in the background to prevent it from overlaying the poster design.
- Update LibraryBrowseScreen and HomeScreen to use the active theme's highlight color for the focus border when viewing genres or genre subitems.
@RadicalMuffinMan RadicalMuffinMan merged commit 65a1cd7 into Moonfin-Client:main Jun 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants