ui:settings - Fix Automation and Queue Next Up Display Setting layout#434
Open
mattsigal wants to merge 1 commit into
Open
ui:settings - Fix Automation and Queue Next Up Display Setting layout#434mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
- Separate the option details from the option buttons in the setting tile. - Replaced hardcoded description with l10n.settingsNextUpDisplayDescription. - Replaced long button labels with short localized strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tame Next Up Display Setting from Causing Chaos and Pain
Summary
Separate option details from the option buttons in the "Next Up Display" setting to resolve setting title text-wrapping layout issues.
Related Issues
Slipped through the cracks during testing.
Type of Change
Changes Made
List the key changes included in this PR.
EnumPreferenceTile<NextUpBehavior>insettings_side_panel.dart:l10n.settingsNextUpDisplayDescriptionto show option details in the setting description block (fully localized).l10n.extended,l10n.minimal, andl10n.noneto prevent horizontal squishing of the settings title.Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
BROKEN
FIXED
Checklist