feat(playback): Add headphone auto-pause on disconnection and fix iOS core functionality#426
Open
mattsigal wants to merge 1 commit into
Open
feat(playback): Add headphone auto-pause on disconnection and fix iOS core functionality#426mattsigal wants to merge 1 commit into
mattsigal wants to merge 1 commit into
Conversation
… play/pause media controls - Listen to AudioSession.becomingNoisyEventStream and pause playback when headphones are disconnected/unplugged. - Add MediaAction.play and MediaAction.pause to systemActions in MoonfinAudioHandler to enable iOS Lock Screen and AirPods Pro media key controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one about EXPERIMENTAL Headphones Support
Summary
This PR adds support for headphone auto-pause when disconnected (e.g., AirPods removal or wired headphone unplug) and fixes media key controls (play/pause) on iOS/iPadOS.
Related Issues
Requested on Discord.
Type of Change
Changes Made
lib/playback/audio_handler.dart): AddedMediaAction.playandMediaAction.pauseto thesystemActionsconfiguration inMoonfinAudioHandler. This allows iOS'sMPRemoteCommandCenterto register play/pause handlers so that AirPods, lock screen, and system control center events are handled (bug fix).lib/main.dart): Configured a listener on theAudioSession'sbecomingNoisyEventStreamthat automatically pauses playback viaPlaybackManager.pause().Platform
Testing
Test Steps
Screenshots (if applicable)
N/A
Checklist