add toggle for full screen home rows#413
Merged
Merged
Conversation
RadicalMuffinMan
requested changes
Jun 7, 2026
| double _v2MetadataHeightBudget(UserPreferences prefs) { | ||
| final hasAdditionalRatings = | ||
| prefs.get(UserPreferences.enableAdditionalRatings); | ||
| final homeRowsFullscreen = |
Contributor
There was a problem hiding this comment.
Suggested change
| final homeRowsFullscreen = | |
| final fullScreenRows = |
| final hasAdditionalRatings = | ||
| prefs.get(UserPreferences.enableAdditionalRatings); | ||
| final homeRowsFullscreen = | ||
| prefs.get(UserPreferences.fullScreenRows); |
Contributor
There was a problem hiding this comment.
Suggested change
| prefs.get(UserPreferences.fullScreenRows); | |
| PlatformDetection.isTV && prefs.get(UserPreferences.fullScreenRows); | |
| if (fullScreenRows) { | |
| return 280.0; | |
| } |
the homeRowsFullscreen check is inside the if (hasAdditionalRatings) block. That means if a user has the "additional ratings" setting turned off, the function returns 136.0 and never even looks at your toggle.
| prefs.get(UserPreferences.fullScreenRows); | ||
| if (hasAdditionalRatings) { | ||
| return PlatformDetection.isTV ? 208.0 : 144.0; | ||
| if (homeRowsFullscreen){ |
Contributor
There was a problem hiding this comment.
Suggested change
| if (homeRowsFullscreen){ |
| if (hasAdditionalRatings) { | ||
| return PlatformDetection.isTV ? 208.0 : 144.0; | ||
| if (homeRowsFullscreen){ | ||
| return 280; |
Contributor
There was a problem hiding this comment.
Suggested change
| return 280; |
| return PlatformDetection.isTV ? 208.0 : 144.0; | ||
| if (homeRowsFullscreen){ | ||
| return 280; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Reduces spacing below modern home rows on TV by default. Adds toggle to enable larger spacing to make rows "full screen"
Related Issues
Link related issues or tickets separated by commas.
Discord discussion. Matt and I have different preferences on this, and some people complained on reddit about the new home row spacing. So you told me to make a toggle. Here is the toggle.
Type of Change
Changes Made
List the key changes included in this PR.
Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
On my device (classic theme sidebar):
Toggle:
Default row height:
Full screen rows:
On @mattsigal device (neon theme top bar):
Default row height:
Full screen rows:
Checklist