Fix D-pad focus in settings preference tiles#411
Merged
RadicalMuffinMan merged 1 commit intoJun 7, 2026
Conversation
Set canRequestFocus to false and skipTraversal to true in TvFocusHighlight. This ensures that D-pad navigation targets focusable descendants (such as ListTile and SwitchListTile) directly, allowing Enter/Select key events to trigger standard onTap and onChanged callbacks and restoring preference toggling capabilities on Android TV / NVidia Shield.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fixes a bug where preference settings tiles (e.g., Media Bar, Navigation Style, Home Row Style, etc.) are not togglable or interactable via D-pad/TV remote navigation.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
canRequestFocustofalseandskipTraversaltotrueon the outerFocusnode withinTvFocusHighlight.ListTileorSwitchListTiledirectly, allowing standard Enter/Select key events to trigger theironTap/onChangedhandlers, while preserving parent-bubbled focus highlight updates.Platform
Testing
Test Steps
Checklist