The Monsters Return#7085
Open
dwasint wants to merge 39 commits into
Open
Conversation
…er den, also broodmother den start.
…ide of this its not really possible without ALOT of fucking
…bs follow through better, fixes virtual paths
This was referenced Jul 8, 2026
Closed
Closed
…non burn by default
…nto the-monsters
This was referenced Jul 9, 2026
| #define HARLEQUINN_VESSEL_ID "Harlequinn" | ||
| #define HARLEQUINN_HUNT_REWARD 500 | ||
|
|
||
| #define PUTRID_VESSEL_ID "Putrid" |
Collaborator
There was a problem hiding this comment.
Make a folder for vessel defines
| icon_state = "runner" | ||
| icon_living = "runner" | ||
| icon_dead = "runner_dead" | ||
| c |
| if(istype(Item, generator_type)) | ||
| continue checking_items | ||
| Item.try_wrap_up("meat", "meatthings") | ||
| for(var/obj/item/Item in T.contents) |
Collaborator
There was a problem hiding this comment.
Suggested change
| for(var/obj/item/Item in T.contents) | |
| for(var/obj/item/Item in T) |
| @@ -1,4 +1,4 @@ | |||
| GLOBAL_LIST_INIT(vessel_ids, list(WHITELIST_AUTOMATON, HARLEQUINN_VESSEL_ID)) | |||
| GLOBAL_LIST_INIT(vessel_ids, list(WHITELIST_AUTOMATON, HARLEQUINN_VESSEL_ID,BROODSPAWN_GOBLIN_VESSEL_ID,BROODSPAWN_TROLL_VESSEL_ID,BROODSPAWN_ORC_VESSEL_ID, BROODMOTHER_VESSEL_ID, PUTRID_VESSEL_ID)) | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| GLOBAL_LIST_INIT(vessel_ids, list(WHITELIST_AUTOMATON, HARLEQUINN_VESSEL_ID,BROODSPAWN_GOBLIN_VESSEL_ID,BROODSPAWN_TROLL_VESSEL_ID,BROODSPAWN_ORC_VESSEL_ID, BROODMOTHER_VESSEL_ID, PUTRID_VESSEL_ID)) | |
| GLOBAL_LIST_INIT(vessel_ids, list( | |
| WHITELIST_AUTOMATON, | |
| HARLEQUINN_VESSEL_I, | |
| BROODSPAWN_GOBLIN_VESSEL_ID, | |
| BROODSPAWN_TROLL_VESSEL_ID, | |
| BROODSPAWN_ORC_VESSEL_ID, | |
| BROODMOTHER_VESSEL_ID, | |
| PUTRID_VESSEL_ID, | |
| )) |
Why does automaton not match
Comment on lines
+167
to
+174
| /datum/pet_command/idle, | ||
| /datum/pet_command/free, | ||
| /datum/pet_command/follow, | ||
| /datum/pet_command/attack, | ||
| /datum/pet_command/protect_owner, | ||
| /datum/pet_command/aggressive, | ||
| /datum/pet_command/calm, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| /datum/pet_command/idle, | |
| /datum/pet_command/free, | |
| /datum/pet_command/follow, | |
| /datum/pet_command/attack, | |
| /datum/pet_command/protect_owner, | |
| /datum/pet_command/aggressive, | |
| /datum/pet_command/calm, | |
| ) | |
| /datum/pet_command/idle, | |
| /datum/pet_command/free, | |
| /datum/pet_command/follow, | |
| /datum/pet_command/attack, | |
| /datum/pet_command/protect_owner, | |
| /datum/pet_command/aggressive, | |
| /datum/pet_command/calm, | |
| ) |
Comment on lines
+415
to
+419
| if(isliving(target)) | ||
| addtimer(CALLBACK(target, TYPE_PROC_REF(/mob, fly_towards), "is yanked towards [caster] by the harpoon!", caster), pull_delay) | ||
|
|
||
| else | ||
| addtimer(CALLBACK(caster, TYPE_PROC_REF(/mob, fly_towards), "is yanked forward by the harpoon line!", target), pull_delay) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if(isliving(target)) | |
| addtimer(CALLBACK(target, TYPE_PROC_REF(/mob, fly_towards), "is yanked towards [caster] by the harpoon!", caster), pull_delay) | |
| else | |
| addtimer(CALLBACK(caster, TYPE_PROC_REF(/mob, fly_towards), "is yanked forward by the harpoon line!", target), pull_delay) | |
| return | |
| if(isliving(target)) | |
| addtimer(CALLBACK(target, TYPE_PROC_REF(/mob, fly_towards), "is yanked towards [caster] by the harpoon!", caster), pull_delay) | |
| else | |
| addtimer(CALLBACK(caster, TYPE_PROC_REF(/mob, fly_towards), "is yanked forward by the harpoon line!", target), pull_delay) |
| damage = 15 | ||
| damage_type = BRUTE | ||
| speed = 1.6 | ||
| var/mob/living/caster |
| icon = 'icons/roguetown/mob/cabbit.dmi' | ||
| icon_state = "cabbit_remains" | ||
|
|
||
| /datum/action/cooldown/spell/harpoon_pull |
Collaborator
There was a problem hiding this comment.
Why is this not a projectile spell?
Comment on lines
+460
to
+467
| /datum/pet_command/idle, | ||
| /datum/pet_command/free, | ||
| /datum/pet_command/follow, | ||
| /datum/pet_command/attack, | ||
| /datum/pet_command/protect_owner, | ||
| /datum/pet_command/aggressive, | ||
| /datum/pet_command/calm, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| /datum/pet_command/idle, | |
| /datum/pet_command/free, | |
| /datum/pet_command/follow, | |
| /datum/pet_command/attack, | |
| /datum/pet_command/protect_owner, | |
| /datum/pet_command/aggressive, | |
| /datum/pet_command/calm, | |
| ) | |
| /datum/pet_command/idle, | |
| /datum/pet_command/free, | |
| /datum/pet_command/follow, | |
| /datum/pet_command/attack, | |
| /datum/pet_command/protect_owner, | |
| /datum/pet_command/aggressive, | |
| /datum/pet_command/calm, | |
| ) |
| var/in_water = istype(current_turf) | ||
|
|
||
| var/mob/living/target | ||
| if(ai_controller) |
Collaborator
There was a problem hiding this comment.
Don't do anything unless the ai controller is present or it will force players to submerge + this should be an innate action so players can use it properly
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
add: putrid
refactor: orcs and goblins now get their stats applied via their species meaning player controlled ones get stats
add: hell goblins explode
add: moon goblins know how to summon a brick
add; broodmother is now playable in game using the vessel system.
refactor: as per the species doc, adds orcs to the generic human body list, letting them wear clothes.
/:cl:
Pre-Merge Checklist