Skip to content

feat: implement MCMP fadein/fadeout support #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctoth merged 1 commit into from
Feb 19, 2026
Merged

feat: implement MCMP fadein/fadeout support #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions src/gmcp/Client/Media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,32 @@ export class GMCPClientMedia extends GMCPPackage {
// Playback control
if (!sound.isPlaying) {
const playback = sound.play()[0] as Playback;
if (data.fadein) {
// Implement fade in functionality
const targetVolume = (data.volume ?? 50) / 100;
const context = this.client.cacophony.context;
const currentTime = context.currentTime;

if (data.fadein && playback.gainNode) {
// Start at 0, ramp to target volume over fadein ms
playback.gainNode.gain.setValueAtTime(0, currentTime);
playback.gainNode.gain.linearRampToValueAtTime(
targetVolume,
currentTime + data.fadein / 1000
);
}
if (data.fadeout) {
// Implement fade out functionality

if (data.fadeout && playback.gainNode) {
// Schedule fadeout at end of sound
const duration = playback.duration;
if (isFinite(duration)) {
const fadeoutStart = currentTime + duration - data.fadeout / 1000;
if (fadeoutStart > currentTime) {
playback.gainNode.gain.setValueAtTime(targetVolume, fadeoutStart);
playback.gainNode.gain.linearRampToValueAtTime(
0,
currentTime + duration
);
}
}
}
}
sound.key = data.key;
Expand Down