Recover the quadbin Quadbin collapsed C type#22
Open
estebanzimanyi wants to merge 1 commit into
Open
Conversation
Quadbin is a typedef of uint64 (meos_quadbin.h). Unlike H3Index — whose name is erased to int by the host-collision prefix rename, so the existing recovery (slot cType == int) catches it — Quadbin's name SURVIVES as the cType while only the canonical collapses to int (its underlying uint64 is the part that erased). So the recovery must also fire when the slot spells the typedef name, not just int. Add "Quadbin": "uint64_t" to the type-recovery map AND generalize the recovery to match either the collapsed `int` spelling or the surviving `original` typedef name, rewriting both cType and the collapsed canonical to uint64_t. Every catalog-driven binding now binds the quadbin cell as a 64-bit integer (bigint), like H3Index, instead of disagreeing on the collapsed int (JMEOS mapped the Quadbin cType to a Pointer; the Spark generator mapped the collapsed int to Integer).
estebanzimanyi
force-pushed
the
fix/recover-quadbin-type
branch
from
4204c7a to
5b04de9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quadbinis atypedef uint64(meos_quadbin.h), so libclang collapses it toint— exactly likeH3Index. It was missing from the type-recovery map, so the catalog reported the collapsedintand bindings disagreed on the quadbin cell type (JMEOS'FunctionsGeneratormaps theQuadbincType to aPointer; the MobilitySpark generator maps the collapsedinttoInteger) — a compile/runtime mismatch for every quadbin function.Add
"Quadbin": "uint64_t"to_TYPE_MAPso the recovered type is reported uniformly and every catalog-driven binding binds the quadbin cell as a 64-bit integer, mirroringH3Index.