Skip to content

ACTION: chalk breaking change #155

Description

@nicolas377

About a month ago, I merged #134 into master, which was a breaking version of chalk. I hadn't properly tested the change, and it seems that chalk has changed directions to use ESM, and not support CommonJS. This can be demonstrated by using the current state of master (at commit 4684574), and running npx extension-cli. You should see this error (unneeded dirs blacked out):

image

I'll be working on fixing this, but this will remain a tracking issue.

Activity

  1. self-assigned this
    on Jan 17, 2022
  2. nicolas377 commented on Jan 17, 2022

    @nicolas377
    CollaboratorAuthor

    @nkrusch wanted to ping you to let you know about this

  3. nicolas377 commented on Jan 17, 2022

    @nicolas377
    CollaboratorAuthor

    I'm going to commit a temporary fix to this, which will just be a reversion to chalk v4. At that point, I'll start work on a PR to use ESM (we may potentially need to use module bundling for that).

  4. added a commit that references this issue on Jan 17, 2022
  5. nicolas377 commented on Jan 17, 2022

    @nicolas377
    CollaboratorAuthor

    @nkrusch I've gotten the master version stable. I won't be making any new commits to master for a while, so if you want to, now would be a great time to do a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions