Skip to content

fix(mmgs): add LIBMMGS_EXPORT to MMGS_Get_triangleQuality declaration#325

Open
kmarchais wants to merge 1 commit into
MmgTools:developfrom
kmarchais:fix/mmgs-get-trianglequality-export
Open

fix(mmgs): add LIBMMGS_EXPORT to MMGS_Get_triangleQuality declaration#325
kmarchais wants to merge 1 commit into
MmgTools:developfrom
kmarchais:fix/mmgs-get-trianglequality-export

Conversation

@kmarchais

Copy link
Copy Markdown

MMGS_Get_triangleQuality is missing LIBMMGS_EXPORT in src/mmgs/libmmgs.h. Every other API function in the header has it. Without it the symbol is not exported from libMmgs.dll on Windows, so downstream consumers of a prebuilt DLL (e.g. conda-forge mmgsuite) hit an unresolved external symbol.

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.30%. Comparing base (ae7d305) to head (90bad59).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #325      +/-   ##
===========================================
- Coverage    50.31%   50.30%   -0.01%     
===========================================
  Files          177      177              
  Lines        47831    47840       +9     
  Branches     10352    10349       -3     
===========================================
+ Hits         24065    24067       +2     
- Misses       16037    16044       +7     
  Partials      7729     7729              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant