Fix the OSL tracker workflow failing on every pull request - #272
Merged
Merged
Conversation
The commit step ran `git add :path/osl-tracker.json`. Git reads a leading colon as pathspec magic, so it never matched the file and the job died with "pathspec ':path/osl-tracker.json' did not match any files" — exit 128 on every run since the workflow was added. A ./ prefix makes it a plain path. The step also tried to push on pull_request events, which cannot work for a fork and would fail once the add succeeded, so it is now limited to push events. The tracker still runs on pull requests, it just does not try to commit the result. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying originos with
|
| Latest commit: |
bdf32d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a175cea.originos.pages.dev |
| Branch Preview URL: | https://fix-osl-tracker-pathspec.originos.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Track OSL Script Changesworkflow has failed on every run since it was added. It is the only check on #271, so that pull request shows red for a reason that has nothing to do with its contents.The bug
:path/is a real directory — it holds the 108 OSL shell commands. Butgit add :path/...makes Git read the leading colon as a pathspec magic prefix rather than a path, so it matches nothing and exits 128. A./prefix makes it a plain path again.The
on: paths:filters are unaffected — GitHub's path filters are not Git pathspecs, which is why the workflow triggers correctly in the first place.Also
The step tried to
git pushonpull_requestevents. That cannot work for a pull request from a fork, so it would have failed at the next line even once thegit addsucceeded. It is now limited topushevents. The tracker script still runs on pull requests, it just no longer tries to commit what it produced.Verified
Ran the real workflow steps locally against this branch:
node .github/scripts/track-osl-changes.js— succeeds, "Tracking complete"git add ./:path/osl-tracker.json— succeeds, where the old form still fails with the error abovegit diff --staged --quiet— correctly reports a staged changeMerging this should turn #271 green without the contributor touching anything.