Repository navigation
Description
Labels requested: bug, needs-triage, cli
Product or interface
Source build or repository tooling
Version
- Source:
main@3c21163(repository version0.7.2), tagv0.7.2=c6c7f28 - Node.js v24.18.0, pnpm 9.12.0
Platform
Windows
OS version and architecture
Windows 11 x64 (build 26200), regional format de-DE
Issue area
Build / CI / source distribution
What happens
pnpm test:release-tools fails on a Windows host whose regional format is not en-US, and with it the whole pnpm verify --profile windows gate chain. The failure is invisible in CI because the hosted runners use an en-US regional format.
✖ suite runner pins its locale, preserves gate arguments and canonicalizes Windows temporary paths
+ actual - expected
+ locale: 'de-DE'
- locale: 'en-US'
Steps to reproduce
-
On a Windows host with a non-English regional format (this report: de-DE), run:
pnpm test:release-tools -
Observe the failure above (exit code 1).
For reference, the same command exits 0 on an en-US Windows host and on Linux/macOS.
Expected and actual behavior
- Expected: the gate passes on every host, because the test asserts what the runner is supposed to guarantee — that the suite runner pins the locale sources it controls.
- Actual: the assertion compares the resolved ICU locale against a hardcoded
'en-US', which on Windows is the host's regional format rather than something the runner controls.
Why this is not a locale-setting problem
The suite runner pins four locale sources before Vitest starts (scripts/run-vitest-suite.mjs):
environment.LANG = "C";
environment.LANGUAGE = "C";
environment.LC_ALL = "C";
environment.LC_MESSAGES = "C";and the test spawns that runner with a deliberately hostile environment (zh_CN.UTF-8) and asserts the child reports 'C' for all four. That part of the assertion is correct and worth keeping.
The failing assertion is the fifth one:
locale: Intl.DateTimeFormat().resolvedOptions().localeOn Linux and macOS the C pins make ICU resolve to en-US. On Windows, ICU ignores the POSIX locale variables and follows the operating system's regional format — so the resolved locale is de-DE here, and no environment variable or Node flag changes it. I looked for one and did not find it: LANG, LANGUAGE, LC_ALL, LC_MESSAGES, LC_TIME, LC_NUMERIC, NODE_ICU_DATA, ICU_DATA, NODE_DEFAULT_LOCALE, --icu-data-dir and the V8 options all leave Intl.DateTimeFormat().resolvedOptions().locale at de-DE on this host.
So the current expectation cannot be satisfied on such a host, and the test's own comment — "Pin every locale source before Vitest starts" — overstates what the pins achieve on Windows.
Where it happens
test/source-sync.test.mjs— the assertion, in the test named "suite runner pins its locale, preserves gate arguments and canonicalizes Windows temporary paths".scripts/run-vitest-suite.mjs— the runner whose locale handling the test describes.
The test simulates three platforms by overriding process.platform in a preloaded module; the real ICU environment of the host stays in place, so the expectation happens to hold for all three simulated platforms on an en-US host and only for the POSIX ones elsewhere.
Suggested fix
Derive the expected locale from a probe that runs in the same pinned environment as the child process, instead of hardcoding 'en-US'. On POSIX the probe yields 'en-US' — the previous expectation — so the change is a no-op there. The four 'C' pin assertions stay untouched and keep their strictness.
A branch with the fix and a regression test is available: test/release-tools-locale-portability on Ralle1976/minimax-code, rebased onto main @ 3c21163 (commit 9c07d9e).
pnpm test:release-tools: exit 1 before, exit 0 after (55 passing, 0 failing, 2 skipped).pnpm verify --profile windows: 9 of 9 gates pass on this host after the change.- The pin assertions remain sharp: removing the pins makes the test fail again (
lang: 'zh_CN.UTF-8'instead of'C'), and restoring the hardcoded expectation makes it fail on this host as well.
Note on the environment
This host also has LongPathsEnabled enabled and a de-DE regional format, so the Windows-specific paths are exercised as a non-en-US contributor would see them. The hosted Windows runners use en-US, which is why CI does not surface this.
Before submitting
- I have searched existing issues.
- I have included my version and removed sensitive information.
Activity