Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GameLocation fires connectionChanged, processChanged and playingChanged where its listeners heard a Change before, in the same order. ItemIconService fires changed on the Swing thread after a newer snapshot; RuntimeIndexService fires statusChanged under its lifecycle lock. Their listener lists go, and with them their exceptions in SystemsRulesTest. SYSTEMS.md puts this before the pages. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Pelotrio
force-pushed
the
claude/systems-owners
branch
from
September 30, 2026 13:52
dd3df86 to
8be04c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth PR of
docs/SYSTEMS.md, stacked on #115: the owners that still told through their own listener lists tell through signals, so the pages PR can make every page follow signals only.Finish line
GameStateTest.followersHearEachChangeOnce,GameStateTest.whatTheGameToldBeforeItsConnectionWasEstablishedCountsItemIconServiceTest.viewsAreToldOnceOnTheSwingThreadOnlyWhenTheSnapshotChangedRuntimeIndexServiceTest,LocalIndexTest,RuntimeIndexRecoveryTestSearchEverywherePopupTest.disposedPopupUnsubscribesAndIgnoresQueuedRuntimeStatusSystemsRulesTest(their exceptions are gone)What changes
GameLocationhas three signals,connectionChanged,processChangedandplayingChanged, instead ofaddListener(Consumer<Change>)and theChangeenum. They fire where the changes fired before, in the same order. Followers read the location for what changed:ConfigChanges,ChangePipeline,Reloads,GamePacks,WorldReading, the configuration pages and the Project tree.ItemIconServicehas achangedsignal, fired on the Swing thread after a newer snapshot was adopted, instead of its listener list. The adoption guard has its own lock object.RuntimeIndexServicehas astatusChangedsignal instead ofaddStatusListenerandremoveStatusListener. The status is set and told under the lifecycle lock, so a follower reads the status that was told.CompanionApplicationand the search popup read the current status once when they start following.docs/SYSTEMS.md: this PR comes before the pages, which can only follow signals; the order table is renumbered. The remaining exceptions inSystemsRulesTestname the PRs that remove them.Left as it is
The debugger's session events, notifications, script runs, search matches and control events keep their listeners. They carry events, not state, as
SystemsRulesTestlists them.:companion:testpasses (1642).🤖 Generated with Claude Code