Follow-ups from the review of resource editing

[Pelotrio]

Rare cases found while reviewing resource editing (#57, #59). Each was judged not to belong in the PR: none of them writes to the wrong file or loses a user's data.

• Registries that mods add through DataPackRegistryEvent sit under data/<ns>/<modid>/<registry>/. Companion classifies them as data that /reload refreshes, so it reports "the game reloaded it" while the game keeps the old value until the world is loaded again. The game knows the real list (RegistryDataLoader plus DataPackRegistriesHooks) and could name it in PACK_STACK.
• Save conflicts between two tabs of one file. Two tabs can show the same managed resource, for example one opened from the mod's JAR and one from the Changes page. A save in one moves the other's baseline, so the other tab's unsaved text can later replace it without asking. A file edited outside Companion while its tab is open is replaced the same way. Configuration text already asks in this case (ConfigWriter.saveText); resources should too.
• A disabled TotalDebug datapack stays disabled for world-load edits. Saving to a folder loaded with the world (worldgen, dimension types and similar) sends no data reload, and only a data reload turns the managed datapack back on. Rejoining keeps the world's disabled state, so the edit never loads (#59).
• Server resource packs above the managed pack send no file source, so Companion cannot tell that one supplies the edited file too, and does not warn that the server's copy wins (#59).
• Pack overlays declared in pack.mcmeta are not applied by the Resources view, so a file an active overlay supplies can show a lower copy as the winner (#60).
• Search Everywhere finds only mods' resources, not those that only an enabled resource pack or the managed pack supplies; it could take the Resources view's joined list (#60).

The earlier items about values tried in the game's memory ended with that feature, which was removed in #59.

🤖 Generated with Claude Code

[Pelotrio]

From #60 review: the joined Resources view ignores filter.block in a higher pack's pack.mcmeta, so resources the game removes from lower packs still appear as used. Parse each source's filter and drop matching lower entries as it is applied.

[Pelotrio]

From #61 review:

• A mod loading issue keeps only the first line of a multi-line Failure message.
• A log entry keeps its first 200 lines without saying it was shortened.

[Pelotrio]

From #62 review:

• A world with only level.dat_old (the game stopped between its two renames) is not chosen as the current world.
• A folder or zip datapack with a corrupt pack.mcmeta is listed as enabled on next load.

[Pelotrio]

From #62 review:

• Explorer.show gives no feedback when the platform can open neither the file nor its folder.
• LinkLabel cannot be focused or activated from the keyboard (mod page and World page Files sections).

[Pelotrio]

From #65 review (#65 (comment)): ResourceEdits merges saves into one reload batch with a single managed flag. If a reload is running and the next batch merges a managed-pack save on one side (e.g. data) with a save into a player's pack on the other (assets), the payload names file/TotalDebug for both reloads, so reloadResources() may enable and move an existing TotalDebug resource pack the player had disabled. Fix: carry the managed pack per side in ReloadPayload (protocol bump), or don't merge batches whose sides differ in managedness.

[Pelotrio]

From #65 review (#65 (comment)): ResourceEdits.revert() into a player's folder pack does not recheck that the pack still has pack.mcmeta (saves do since f7a5d33), so a revert after the pack lost it reports an effect the game won't see. Decide whether the revert should still restore the file (so the change can be cleared) but report that the game does not load the pack, rather than fail.

[Pelotrio]

From #65 review (#65 (comment)): offline, the Resources page's Files tab joins the current world's datapacks but reloads only on catalog, pack-stack and edit changes. If the current world or its datapacks folder changes while no game is connected, the tab keeps the old join. Reloading the whole join on every show is heavy; better watch the world's level.dat/datapacks folder (or the most recently played world) and reload on change.

[Pelotrio]

From #65 review (#65 (comment)): PackFolders.isPack accepts a folder or zip with any pack.mcmeta, while Minecraft drops a pack whose metadata is malformed or lacks pack/pack_format. Such a pack is listed, offered under Save into, and offline an edit in it is reported as applying. Validate the metadata (as PackFolders.meta already parses it) and say why a pack is not loadable.

[Pelotrio]

From #66 review (#66 (comment)): the texture editor keeps the animation (.png.mcmeta) of the file that was opened when it shows the working pack's copy. If that copy's animation differs (other frame size or order), the frame slider and playback follow the opened file's frames; drawing still changes the pixels shown. Read the target pack's .mcmeta with its PNG and rebuild the viewer's frames.

[Pelotrio]

From #66 review round 3 (#66):

• ResourceEdits.managed reads a pack's copy with an unbounded Files.readAllBytes before the texture editor checks its header, so a huge or badly compressed .png in the working pack is read whole; apply ResourceLoader.MAXIMUM_PNG_BYTES (and the text limit) while reading.
• The image viewer's toolbar is one FlowLayout row: in a narrow tab, the texture tools (with an animation's slider) wrap into a row BorderLayout.NORTH does not size, so the colors or undo/redo are clipped; give the editing controls their own row or a wrapping layout.

[Pelotrio]

From #69 review (#69 (comment)): a .png.mcmeta copied beside a saved texture can be overridden by a pack above that supplies only the .mcmeta (metadata comes from the highest pack at or above the PNG's), and the save's unused check looks at the PNG path only, so the editor reports the animation as in use. Check added companion paths with unusedBecause too.

[Pelotrio]

From the third review of #71:

• Texture saved into a pack that already has its .mcmeta but no PNG. ResourceEdits.save keeps the pack's own animation file, but the tab adopts the animation of the copy it showed before. Decode the saved copy against the destination pack's metadata after the save.
• Render scenario for the Show in Explorer failure notice (Pack, World, Packs and Configuration pages). Explorer.show needs a seam so the UI harness can make it fail without opening the file manager, then a UiRenderScenario case that renders the notice in both themes.