Skip to content

Follow-ups from the review of the inspection and modpack stack #56

Description

@Pelotrio

Edge cases and known limitations from the pair review of the stack #48 to #55 (Astra, Claude and Codex). Each was judged not to belong in the stack: none writes to the wrong file or loses a user's data. The links lead to the review comment.

Inspection page

  • A tool's output or failure longer than 256 characters is clipped on the page; the full text is only in the tool's run (#53).
  • A block without an unsided handler, whose faces expose equally large handlers, shows the amounts of only one of them (#53).

Catalog and search

  • An empty-string default cannot be told apart from an unknown default in the catalog, so such settings never count as modified (#50).
  • A range bound equal to another type's limit, such as a long setting ranged to Integer.MAX_VALUE, reads as no bound, because the catalog does not record a setting's numeric type (#55).
  • Mods embedded in other jars (jij:) cannot be browsed in Resources or Search Everywhere (#50).
  • Search Everywhere filters resources by the namespace owner, not by the archive that contains them (#50).
  • The tint probe checks tint indices 0 to 3 before capturing an item's tint map (#50).

Configuration and key bindings

  • Reverting a change offline, when the catalog no longer describes its file, reports the effect of a common configuration (#51).
  • An I/O failure while listing worlds reads as "no world has the file" (#51).
  • A key change the game applied, whose reply was lost in a disconnect, cannot be confirmed or recorded. A future reconciliation should keep that uncertainty, not assume success because the current key matches (#51).
  • List values are checked on a best-effort basis from their current and default elements. NeoForge's own element checks are not captured. A future authoritative check should replace this inference, not extend it.

Rendering and UI

  • Generated-model geometry can grow very large for a high-resolution texture whose alpha alternates at every texel. The pixel limit bounds the decode, but not the generated geometry. The production icon service uses this renderer too (#48).
  • A live theme or UI-scale change reaches only views that are open and attached to a window. A hidden popup keeps its tooltip colours, and an open form keeps its row gaps, until they are created again (#55, #55).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions