chore: track all errors in handle middleware WPN-1451

[taran-a]

Explanation

Improves Snap observability and trace handling by centralizing error/event tracking resilience in SnapClientAdapter, broadening HandlerMiddleware to track unexpected errors, and skipping tracking for user-canceled confirmations. It also simplifies callers by removing runSnapActionSafely, updates trace semantics so endTrace only runs when startTrace succeeds, and adds/refreshes tests covering the new tracking and tracing behavior.

References

• Fixes WPN-1451

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Medium Risk
Touches cross-cutting error/telemetry paths and cron partial-sync behavior; failures in tracking are swallowed (by design) which could hide telemetry outages but should not block user flows.

Overview
Improves Bitcoin Snap observability by making telemetry non-fatal and tracking more consistent across handlers and use cases.

SnapClientAdapter now takes a Logger, wraps snap_trackEvent, snap_trackError, snap_startTrace, and snap_endTrace in try/catch (log on failure, never throw), sends errors via getJsonError, and changes startTrace to return boolean so callers only call endTrace when start succeeded.

HandlerMiddleware tracks errors before translation/wrapping for any thrown error via new shouldTrackError (skips "User canceled the confirmation"). BaseError-only tracking in the middleware catch path is removed in favor of this broader path.

Call sites drop runSnapActionSafely and call tracking directly; emitTrackingError is wired into asset price/historical failures, partial cron sync failures, keyring address resolution failures, send-flow/confirmation graceful fallbacks, and related paths. User-input validation (RPC address/amount, some send-form fields) stays untracked by design.

SnapClient types update emitTrackingError to accept Error and document the new trace return type. Tests cover adapter resilience, middleware tracking rules, and updated trace behavior.

^{Reviewed by Cursor Bugbot for commit 3e84cde. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8406c25. Configure here.}

[github-actions]

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.14.1-preview-fc27456"
}

[taran-a]

@metamaskbot publish-preview

[github-actions]

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.14.1-preview-3e84cde"
}