feat(pr-workflow): add pr-validate skill — evidence-based PR validation#56
Draft
MajorLift wants to merge 8 commits into
Draft
feat(pr-workflow): add pr-validate skill — evidence-based PR validation#56MajorLift wants to merge 8 commits into
MajorLift wants to merge 8 commits into
Conversation
… sibling pointers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
pr-validateskill to thepr-workflowdomain: the evidence-orchestration / claim-matching layer for proving a PR's behavioral claim before review or merge.Why
We have capture skills (
testing/visual-testing,testing/performance-testing,pr-manual-testing) and readiness checks (pr-readiness-check), but nothing that decides what evidence a PR's specific claim needs and assembles it.pr-validatefills that gap and defers capture to the existing skills rather than duplicating them.How it fits
pr-readiness-check(presence of tests/guidelines) by proving the behavior is correct.visual-testing(mm CLI),performance-testing,pr-manual-testing,pr-description.visual_validation/perf_validation) as an autonomous evidence engine at the capability level.Files
domains/pr-workflow/skills/pr-validate/skill.mddomains/pr-workflow/skills/pr-validate/repos/metamask-extension.mdOpened as draft for maintainer feedback on domain placement (pr-workflow vs testing) and scope of the AEP section.