Skip to content

feat(perps): add multiproject validation skill#48

Open
abretonc7s wants to merge 5 commits into
mainfrom
perps/multiproject-validation-skill
Open

feat(perps): add multiproject validation skill#48
abretonc7s wants to merge 5 commits into
mainfrom
perps/multiproject-validation-skill

Conversation

@abretonc7s

Copy link
Copy Markdown
Contributor

Summary

  • Add a Perps multiproject validation skill for checking Core controller changes in Mobile/Extension or client parity across Mobile and Extension.
  • Add component-view test coverage guidance to the Perps review checklist and Extension overlay.
  • Keep the validation workflow default-driven: current checkout as owner, sibling repo discovery, yalc for Core package transport, read-only targets, and explicit cleanup.

Validation

  • node bin/metamask-skills.mjs describe perps/validate-perps-multiproject
  • node bin/metamask-skills.mjs list --domain perps --include perps/validate-perps-multiproject
  • yarn smoke
  • yarn test

Follow-up

  • Extension/mobile farm fixtures should consume this guidance from MetaMask skills instead of copying it into project-specific fixture text.

…iled usage instructions and error handling guidelines
…ect checks

- Added `scripts/perps-validate.sh` to automate the validation process for Core changes in client checkouts (Mobile and Extension).
- Enhanced documentation in `skill.md` with detailed usage instructions and error handling guidelines.
- Emphasized the importance of pre-state awareness and yalc resolution in the validation workflow.
@abretonc7s abretonc7s marked this pull request as ready for review June 26, 2026 16:06
…repoNameFromGitHubUrl regex

- Introduced `inferRepoFromBasename` to map directory names to corresponding MetaMask repositories.
- Updated regex in `repoNameFromGitHubUrl` to support SSH host aliases for multi-account git configurations.
- Added unit tests for both functions to ensure correct behavior and coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant