Skip to content

DUX-5115 Add startup failure error log test#449

Merged
9999years merged 1 commit into
mainfrom
wiggles/dux-5115/ursm
Apr 29, 2026
Merged

DUX-5115 Add startup failure error log test#449
9999years merged 1 commit into
mainfrom
wiggles/dux-5115/ursm

Conversation

@9999years
Copy link
Copy Markdown
Member

@9999years 9999years commented Apr 29, 2026

#444 got auto-merged a bit early, oops!

I can confirm that if you comment out the change in #444 then a bunch of stuff fails:

     Summary [  83.049s] 239 tests run: 227 passed (1 leaky), 12 failed, 0 skipped
        FAIL [  36.712s] ghciwatch::error_log error_log_startup_failure_9102
        FAIL [  24.564s] ghciwatch::error_log error_log_startup_failure_9122
        FAIL [  22.095s] ghciwatch::error_log error_log_startup_failure_967
        FAIL [  33.764s] ghciwatch::error_log error_log_startup_failure_984
        FAIL [  22.941s] ghciwatch::shutdown handles_repeated_startup_failures_9102
        FAIL [  24.139s] ghciwatch::shutdown handles_repeated_startup_failures_9122
        FAIL [  25.440s] ghciwatch::shutdown handles_repeated_startup_failures_967
        FAIL [  27.936s] ghciwatch::shutdown handles_repeated_startup_failures_984
        FAIL [  27.663s] ghciwatch::shutdown handles_repeated_startup_failures_before_restart_ghci_hook_9102
        FAIL [  25.208s] ghciwatch::shutdown handles_repeated_startup_failures_before_restart_ghci_hook_9122
        FAIL [  22.660s] ghciwatch::shutdown handles_repeated_startup_failures_before_restart_ghci_hook_967
        FAIL [  31.145s] ghciwatch::shutdown handles_repeated_startup_failures_before_restart_ghci_hook_984

#444 got auto-merged a bit early, oops!
@linear
Copy link
Copy Markdown

linear Bot commented Apr 29, 2026

Comment thread src/ghci/manager.rs

async fn restart(&mut self) -> eyre::Result<()> {
match self {
handle_broken_pipe(match self {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function also calls initialize under the hood.

@9999years 9999years marked this pull request as ready for review April 29, 2026 00:17
@9999years 9999years requested a review from a team as a code owner April 29, 2026 00:17
@9999years 9999years requested review from lf- and parsonsmatt April 29, 2026 00:17
@9999years 9999years enabled auto-merge (squash) April 29, 2026 00:20
@9999years 9999years merged commit 4837bb9 into main Apr 29, 2026
39 checks passed
@9999years 9999years deleted the wiggles/dux-5115/ursm branch April 29, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants