DUX-5107 Error log: Use errors as a proxy for a summary#441
Merged
Conversation
On startup with `--repl-no-load`, we don't get an "Ok, n modules loaded" or "Failed, n modules loaded" message, so we filled that in with an empty success message. But we can get compilation errors, and those are not "All good"! So let's use the presence of compilation errors as a proxy for success (again, only at startup) in cases where no compilation summary is printed explicitly.
9999years
force-pushed
the
wiggles/dux-5107/lowt
branch
from
1f49770 to
4b2b869
Compare
dtpowl
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On startup with
--repl-no-load, we don't get an "Ok, n modules loaded" or "Failed, n modules loaded" message, so we filled that in with an empty success message.But we can get compilation errors, and those are not "All good"! So let's use the presence of compilation errors as a proxy for success (again, only at startup) in cases where no compilation summary is printed explicitly.