DUX-5106 miette -> eyre#440
Merged
Merged
Conversation
`miette::IntoDiagnostic` hides the original error from downcasting methods, which means that it's impossible (in the rare cases where we want one) to get an error _out_ of a `miette::Result` to match on it. `IntoDiagnostic` is mandatory for error types that don't implement `miette::Diagnostic`, which (inherently) includes all of the `std` error types. I could define my own wrapper types for everything I want to match on, but that's a big hassle that just isn't worth it. This has been an open issue for 4 years now, but we haven't really needed to match on inner errors before. Now that we do, it's a dealbreaker. See: zkat/miette#155
dtpowl
approved these changes
Apr 28, 2026
| itertools = "0.11.0" | ||
| miette = { version = "5.9.0", features = ["fancy"] } | ||
| nix = { version = "0.26.2", default-features = false, features = ["process", "signal"] } | ||
| eyre = "*" |
Member
Author
There was a problem hiding this comment.
It's pinned in the top-level Cargo.toml, so this will just resolve to the same version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miette::IntoDiagnostichides the original error from downcasting methods, which means that it's impossible (in the rare cases where we want one) to get an error out of amiette::Resultto match on it.IntoDiagnosticis mandatory for error types that don't implementmiette::Diagnostic, which (inherently) includes all of thestderror types. I could define my own wrapper types for everything I want to match on, but that's a big hassle that just isn't worth it.This has been an open issue for 4 years now, but we haven't really needed to match on inner errors before. Now that we do, it's a dealbreaker.
See: zkat/miette#155