DUX-5101 No "All good" after startup#438
Merged
Merged
Conversation
With `--repl-no-load`, we don't get a compilation summary message ("Ok,
123 modules loaded."), so if everything went well we write... an _empty_
error log, which is not helpful.
Let's synthesize a message in this case: "All good (0 modules)".
9999years
force-pushed
the
wiggles/dux-5101/kvsz
branch
from
b5655d1 to
a87ffb3
Compare
hdgarrood
approved these changes
Apr 28, 2026
9999years
added a commit
that referenced
this pull request
Apr 28, 2026
9999years
added a commit
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--repl-no-load, we don't get a compilation summary message ("Ok, 123 modules loaded."), so if everything went well we write... an empty error log, which is not helpful.Let's synthesize a message in this case: "All good (0 modules)".
NB: If compilation for a dependency fails during startup, we don't yet handle that.