CI: Replace Garnix with GHA#396
Open
9999years wants to merge 1 commit into
Open
Conversation
| name: CI | ||
|
|
||
| on: | ||
| pull_request: |
Contributor
There was a problem hiding this comment.
Should this also run on pushes to main?
| matrix: | ||
| platform: | ||
| - runner: ubuntu-latest | ||
| system: x86_64-linux |
Contributor
There was a problem hiding this comment.
This might be WIP, but it seems like the system is not used and could be condensed to:
platform:
- runner: ubuntu-latest
- runner: macos-latest
Contributor
There was a problem hiding this comment.
.config/nextest.toml still references garnix, should that be updated too?
| - name: Checkout code | ||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
|
|
||
| - uses: cachix/install-nix-action@7be5dee1421f63d07e71ce6e0a9f8a4b07c2a487 # v31.6.1 |
Contributor
There was a problem hiding this comment.
Would a caching step after this one be beneficial?
| github_access_token: ${{ secrets.GITHUB_TOKEN }} | ||
| extra_nix_config: | | ||
| extra-experimental-features = nix-command flakes | ||
| accept-flake-config = true |
Contributor
There was a problem hiding this comment.
Suggested change
| accept-flake-config = true |
Isn't that setting a no-op since the nixConfig was removed from flake.nix?
Sorry Garnix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry Garnix!